This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add confirmation dialog to kick/ban buttons #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a specific dialog used for confirming member actions. Also remove onFinished from MemberInfo which did absolutely nothing.
|
On ,onFinished is used... albeit in a very subtle way.
I suppose is commented so you could argue that it's really not being used, but then I would also remove that commented stuff for good. |
lukebarnard1
suggested changes
Feb 14, 2017
| /* | ||
| * A dialog for confirming an operation on another user. | ||
| * Takes a user ID and a verb, displays the target user prominently | ||
| * such that it should be easy to confirm that tne operation is being |
| export default React.createClass({ | ||
| displayName: 'ConfirmUserActionDialog', | ||
| propTypes: { | ||
| member: React.PropTypes.object.isRequired, // member object |
There was a problem hiding this comment.
Could use PropTypes.shape to indicate what properties member should have.
There was a problem hiding this comment.
Thought about it, although it's a standard JS SDK member object.
There was a problem hiding this comment.
oh ok.. I wished there was a thing for this but I don't think there is... maybe change the comment so that it's obvious that member is a RoomMember?
There was a problem hiding this comment.
oh.. you did that, in that case LGTM
That I've now broken such that it wouldnt work if it were uncommented
|
Oh, good spot. I've removed the commented out stuff. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a specific dialog used for confirming member actions.
Also remove onFinished from MemberInfo which did absolutely
nothing.
Requires element-hq/element-web#3224
Fixes element-hq/element-web#3218