Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Allow reordering of the space panel via Drag and Drop #6137

Merged
merged 24 commits into from
Jun 22, 2021

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jun 3, 2021

@SimonBrandner

This comment has been minimized.

@t3chguy
Copy link
Member Author

t3chguy commented Jun 3, 2021

Yup, it doesn't handle the case of undefined orders where it has to send multiple events properly yet. My local copy works better :P

See https://github.com/matrix-org/matrix-react-sdk/pull/6137/files#diff-6c1ab70872ce2ba309156c1f3e7127eed1e806f9003c0b782a4edbb55e13f6a2R651-R670

@t3chguy t3chguy requested review from a team June 15, 2021 07:27
@t3chguy t3chguy marked this pull request as ready for review June 15, 2021 07:27
src/components/structures/AutoHideScrollbar.tsx Outdated Show resolved Hide resolved
src/components/structures/SpaceRoomDirectory.tsx Outdated Show resolved Hide resolved
src/components/views/spaces/SpacePanel.tsx Outdated Show resolved Hide resolved
src/utils/arrays.ts Outdated Show resolved Hide resolved
src/utils/stringOrderField.ts Outdated Show resolved Hide resolved
src/utils/stringOrderField.ts Outdated Show resolved Hide resolved
test/utils/stringOrderField-test.ts Outdated Show resolved Hide resolved
test/utils/stringOrderField-test.ts Outdated Show resolved Hide resolved
@t3chguy t3chguy requested a review from turt2live June 16, 2021 11:13
t3chguy added 4 commits June 22, 2021 21:15
… t3chguy/fix/17282

� Conflicts:
�	package.json
�	src/components/views/spaces/SpacePanel.tsx
�	src/i18n/strings/en_EN.json
�	src/stores/SpaceStore.tsx
�	yarn.lock
… t3chguy/fix/17282

� Conflicts:
�	package.json
�	yarn.lock
@t3chguy t3chguy merged commit bbcd642 into develop Jun 22, 2021
@t3chguy t3chguy deleted the t3chguy/fix/17282 branch June 22, 2021 20:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow top level spaces to be reordered
4 participants