This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add security customisation points #5327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jryans
added a commit
to element-hq/element-web
that referenced
this pull request
Oct 15, 2020
matrix-org/matrix-react-sdk#5327 adds a concept of "customisation points" to keep custom functionality contained. This adds some general guidance on how to use them.
turt2live
approved these changes
Oct 15, 2020
src/async-components/views/dialogs/security/CreateSecretStorageDialog.js
Outdated
Show resolved
Hide resolved
This adds various customisations point in the app for security related decisions. By default, these do nothing, but would be customised at the app level via module replacement (so that no changes are needed here in the SDK). Fixes element-hq/element-web#15350
jryans
force-pushed
the
jryans/sso-4s-integration
branch
from
fb0a30d to
388cb0e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds various customisations point in the app for security related
decisions. By default, these do nothing, but would be customised at the
app level via module replacement (so that no changes are needed here in the
SDK).
See also element-hq/element-web#15475 for usage documentation.
Fixes element-hq/element-web#15350