Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add security customisation points #15350

Closed
jryans opened this issue Oct 1, 2020 · 1 comment · Fixed by matrix-org/matrix-react-sdk#5327
Closed

Add security customisation points #15350

jryans opened this issue Oct 1, 2020 · 1 comment · Fixed by matrix-org/matrix-react-sdk#5327
Assignees
@jryans
Labels
A-E2EE-Key-Backup Sponsored

Comments

@jryans
Copy link
Collaborator

jryans commented Oct 1, 2020 •
edited
Loading

Some deployments would like to manage a user's 4S key within their SSO system, rather than prompting for it in Element itself, effectively simplifying the UX for cases where users can / are required to trust their SSO identity provider.

Element would receive the 4S key as part of the homeserver's token login response (recently added to Synapse) and Element would then create / access 4S using this key as needed for Secure Backup features.

Since this a fairly specific feature, we'll add some generic customisation points to Element that can be used to enable something like this.
@jryans jryans self-assigned this Oct 1, 2020
@jryans jryans mentioned this issue Oct 7, 2020
Merged
jryans added a commit to matrix-org/matrix-js-sdk that referenced this issue Oct 9, 2020
@jryans
Adjust types and APIs to match React SDK
e9590e9 
Various small tweaks and alignments to match React SDK as part of TypeScript
conversion.

Part of element-hq/element-web#15350
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Oct 9, 2020
@jryans
Store Secure Backup key in app storage
2ea5555 
Some deployments provide a Secure Backup key from an identity system via token
login, which we'll store in app storage.

Part of element-hq/element-web#15350
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Oct 9, 2020
@jryans
Convert src/SecurityManager.js to TypeScript
5d34740 
This includes a few small API tweaks as well, only in cases where TS revealed we
were doing something confusing or wrong.

Part of element-hq/element-web#15350
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Oct 9, 2020
@jryans
Convert src/SecurityManager.js to TypeScript
2698a12 
This includes a few small API tweaks as well, only in cases where TS revealed we
were doing something confusing or wrong.

Part of element-hq/element-web#15350
This was referenced Oct 9, 2020
Merged
Merged
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Oct 15, 2020
@jryans
Add security customisation points
fb0a30d 
This adds various customisations point in the app for security related
decisions. By default, these do nothing, but would be customised at the
app level via module replacement (so that no changes are needed here in the
SDK).

Fixes element-hq/element-web#15350
@jryans jryans mentioned this issue Oct 15, 2020
Merged
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Oct 16, 2020
@jryans
Add security customisation points
388cb0e 
This adds various customisations point in the app for security related
decisions. By default, these do nothing, but would be customised at the
app level via module replacement (so that no changes are needed here in the
SDK).

Fixes element-hq/element-web#15350
@jryans jryans changed the title Support 4S key from SSO provider Add security customisation points Oct 16, 2020
@jryans
Copy link
Collaborator Author

jryans commented Oct 16, 2020

This issue evolved over time into a way of adding security customisation points to allow for custom behaviour that might be needed in different deployments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-E2EE-Key-Backup Sponsored
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add security customisation points matrix-org/matrix-react-sdk
1 participant
@jryans