Only add a local receipt if it's after an existing receipt #3399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybalaam
force-pushed
the
andybalaam/only-add-local-receipt-if-after-existing
branch
from
9581fbb to
cf6975a
Compare
andybalaam
force-pushed
the
andybalaam/only-add-local-receipt-if-after-existing
branch
from
cf6975a to
63c530d
Compare
andybalaam
force-pushed
the
andybalaam/only-add-local-receipt-if-after-existing
branch
from
63c530d to
37bb4c2
Compare
andybalaam
changed the title
weeman1337
reviewed
May 25, 2023
Comment on lines
+516
to
+525
| it("Creates a local echo receipt for new events", async () => { | ||
| // Assumption: no server side support because if we have it, events | ||
| // can only be added to the timeline after the thread has been | ||
| // initialised, and we are not properly initialising it here. | ||
| expect(Thread.hasServerSideSupport).toBe(FeatureSupport.None); | ||
|
|
||
| // Given a client WITH relations recursion support | ||
| const client = createClientWithEventMapper( | ||
| new Map([[Feature.RelationsRecursion, ServerSupport.Stable]]), | ||
| ); |
There was a problem hiding this comment.
This could go to a beforeEach block because it is shared code.
There was a problem hiding this comment.
I hate beforeEach blocks https://www.artificialworlds.net/blog/2013/03/27/setup-and-teardown-considered-harmful/ :-)
andybalaam
deleted the
andybalaam/only-add-local-receipt-if-after-existing
branch
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Dec 13, 2023
* Ensure we do not add relations to the wrong timeline ([\matrix-org#3427](matrix-org#3427)). Fixes element-hq/element-web#25450 and element-hq/element-web#25494. * Deprecate `QrCodeEvent`, `SasEvent` and `VerificationEvent` ([\matrix-org#3386](matrix-org#3386)). * Move crypto classes into a separate namespace ([\matrix-org#3385](matrix-org#3385)). * Mention deno support in the README ([\matrix-org#3417](matrix-org#3417)). Contributed by @sigmaSd. * Mark room version 10 as safe ([\matrix-org#3425](matrix-org#3425)). * Prioritise entirely supported flows for UIA ([\matrix-org#3402](matrix-org#3402)). * Add methods to terminate idb worker ([\matrix-org#3362](matrix-org#3362)). * Total summary count ([\matrix-org#3351](matrix-org#3351)). Contributed by @toger5. * Audio concealment ([\matrix-org#3349](matrix-org#3349)). Contributed by @toger5. * Correctly accumulate sync summaries. ([\matrix-org#3366](matrix-org#3366)). Fixes element-hq/element-web#23345. * Keep measuring a call feed's volume after a stream replacement ([\matrix-org#3361](matrix-org#3361)). Fixes element-hq/element-call#1051. * Element-R: Avoid uploading a new fallback key at every `/sync` ([\matrix-org#3338](matrix-org#3338)). Fixes element-hq/element-web#25215. * Accumulate receipts for the main thread and unthreaded separately ([\matrix-org#3339](matrix-org#3339)). Fixes element-hq/element-web#24629. * Remove spec non-compliant extended glob format ([\matrix-org#3423](matrix-org#3423)). Fixes element-hq/element-web#25474. * Fix bug where original event was inserted into timeline instead of the edit event ([\matrix-org#3398](matrix-org#3398)). Contributed by @andybalaam. * Only add a local receipt if it's after an existing receipt ([\matrix-org#3399](matrix-org#3399)). Contributed by @andybalaam. * Attempt a potential workaround for stuck notifs ([\matrix-org#3384](matrix-org#3384)). Fixes element-hq/element-web#25406. Contributed by @andybalaam. * Fix verification bug with `pendingEventOrdering: "chronological"` ([\matrix-org#3382](matrix-org#3382)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest reviewing commit by commit.
This fixes a part that was missing from Attempt a potential workaround for stuck notifs - that PR inserted events that have arrived in the wrong order into (approx) the correct place in the timeline.
This change refuses to make a local echo receipt for a late-arriving event. We always consider synthesised receipts as the most important, so by making one for an old event, we were fooling ourselves into thinking newer stuff hadn't been read.
(This only applies when we don't have server support for recursive relations. When we do, we will simply trust the order of events from the server, so we won't consider timestamps - we'll just know the most recent event from the server is the most recent event, so it should get a receipt.)
Part of element-hq/element-web#10954
Here's what your changelog entry will look like:
🐛 Bug Fixes