Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synthetic names for unnamed 3-way rooms are useless. #23345

Closed
ara4n opened this issue Sep 23, 2022 · 1 comment · Fixed by matrix-org/matrix-js-sdk#3366
Closed

Synthetic names for unnamed 3-way rooms are useless. #23345

ara4n opened this issue Sep 23, 2022 · 1 comment · Fixed by matrix-org/matrix-js-sdk#3366
Labels
A-DMs A-Room-List O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement

Comments

@ara4n
Copy link
Member

ara4n commented Sep 23, 2022

Your use case

Currently three-way rooms get named "Alice and two others". This is utterly stupid, given one of the members is you. Instead, it should be "Alice and Bob". Otherwise you can't search on Bob to find it, and you can't see that Bob is in it. You know that you're in it, so you don't care about that.

Have you considered any alternatives?

It might not be so bad if searching searched on membership, but even then, you want a sensible name.

Additional context

No response
@SimonBrandner SimonBrandner added A-Room-List A-DMs O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Sep 23, 2022
@uhoreg uhoreg added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely and removed O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Sep 23, 2022
@ara4n
Copy link
Member Author

ara4n commented May 16, 2023

This looks to be a regression, given we have a passing test in js-sdk for:

        it("should return 'User B and User C' if in a room with two other users", function () {

ara4n added a commit to matrix-org/matrix-react-sdk that referenced this issue May 16, 2023
@ara4n
fix three-way default room names
2376d45 
closes element-hq/element-web#23345
unbreaks the regression in 5aae974
matches the default behaviour in js-sdk, as per https://github.com/matrix-org/matrix-js-sdk/blob/develop/spec/unit/room.spec.ts
ara4n added a commit to matrix-org/matrix-js-sdk that referenced this issue May 16, 2023
@ara4n
correctly accumulate sync summaries.
18722d0 
if a sync summary for (say) invited_member_count goes from 1 to 0, it should be
accumluated as 0, rather than 1.

Should fix element-hq/element-web#23345
@ara4n ara4n mentioned this issue May 16, 2023
Merged
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Dec 13, 2023
@su-ex
Merge tag 'v26.0.0' into sc
54d9823 
* Ensure we do not add relations to the wrong timeline ([\matrix-org#3427](matrix-org#3427)). Fixes element-hq/element-web#25450 and element-hq/element-web#25494.
* Deprecate `QrCodeEvent`, `SasEvent` and `VerificationEvent` ([\matrix-org#3386](matrix-org#3386)).
* Move crypto classes into a separate namespace ([\matrix-org#3385](matrix-org#3385)).
* Mention deno support in the README ([\matrix-org#3417](matrix-org#3417)). Contributed by @sigmaSd.
* Mark room version 10 as safe ([\matrix-org#3425](matrix-org#3425)).
* Prioritise entirely supported flows for UIA ([\matrix-org#3402](matrix-org#3402)).
* Add methods to terminate idb worker ([\matrix-org#3362](matrix-org#3362)).
* Total summary count ([\matrix-org#3351](matrix-org#3351)). Contributed by @toger5.
* Audio concealment ([\matrix-org#3349](matrix-org#3349)). Contributed by @toger5.
* Correctly accumulate sync summaries. ([\matrix-org#3366](matrix-org#3366)). Fixes element-hq/element-web#23345.
* Keep measuring a call feed's volume after a stream replacement ([\matrix-org#3361](matrix-org#3361)). Fixes element-hq/element-call#1051.
* Element-R: Avoid uploading a new fallback key at every `/sync` ([\matrix-org#3338](matrix-org#3338)). Fixes element-hq/element-web#25215.
* Accumulate receipts for the main thread and unthreaded separately ([\matrix-org#3339](matrix-org#3339)). Fixes element-hq/element-web#24629.
* Remove spec non-compliant extended glob format ([\matrix-org#3423](matrix-org#3423)). Fixes element-hq/element-web#25474.
* Fix bug where original event was inserted into timeline instead of the edit event ([\matrix-org#3398](matrix-org#3398)). Contributed by @andybalaam.
* Only add a local receipt if it's after an existing receipt ([\matrix-org#3399](matrix-org#3399)). Contributed by @andybalaam.
* Attempt a potential workaround for stuck notifs ([\matrix-org#3384](matrix-org#3384)). Fixes element-hq/element-web#25406. Contributed by @andybalaam.
* Fix verification bug with `pendingEventOrdering: "chronological"` ([\matrix-org#3382](matrix-org#3382)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-DMs A-Room-List O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

correctly accumulate sync summaries. matrix-org/matrix-js-sdk
3 participants
@uhoreg @ara4n @SimonBrandner