Element-R: pass device list change notifications into rust crypto-sdk #3254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianduros
commented
Apr 5, 2023
florianduros
force-pushed
the
florianduros/feat/add-device-list-new-crypto
branch
from
88b92a2 to
5812842
Compare
# Conflicts: # spec/integ/sliding-sync-sdk.spec.ts
richvdh
changed the title
richvdh
requested changes
Apr 6, 2023
|
I'm just going to merge this, despite the quality gate not being satisfied. Ultimately this sort of thing can be covered in |
texuf
pushed a commit
to texuf/matrix-js-sdk
that referenced
this pull request
Apr 17, 2023
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Apr 25, 2023
* Change `Store.save()` to return a `Promise` ([\matrix-org#3221](matrix-org#3221)). Contributed by @texuf. * Add typedoc-plugin-mdn-links ([\matrix-org#3292](matrix-org#3292)). * Annotate events with executed push rule ([\matrix-org#3284](matrix-org#3284)). Contributed by @kerryarchibald. * Element-R: pass device list change notifications into rust crypto-sdk ([\matrix-org#3254](matrix-org#3254)). Fixes element-hq/element-web#24795. Contributed by @florianduros. * Support for MSC3882 revision 1 ([\matrix-org#3228](matrix-org#3228)). Contributed by @hughns. * Fix screen sharing on Firefox 113 ([\matrix-org#3282](matrix-org#3282)). Contributed by @tulir. * Retry processing potential poll events after decryption ([\matrix-org#3246](matrix-org#3246)). Fixes element-hq/element-web#24568. * Element-R: handle events which arrive before their keys ([\matrix-org#3230](matrix-org#3230)). Fixes element-hq/element-web#24489.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Closes element-hq/element-web#24795
Pass device list from
/syncto the new crypto.handleDeviceListChangesmethod intoprocessDeviceListsto match the method names in theCryptoBackendinterface. ie:processKeyCounts,preprocessToDeviceMessagessyncDeviceListparameter todeviceListto match the parameter names inprocessXXorpreprocessXXmethods.Here's what your changelog entry will look like:
✨ Features