Rooms without an unread badge show up in "unread" tab #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- First implementation
- Apply search query to the recents section
- update after code review
- Changed MXRecentsRoomListDataFetcher to MXBreadcrumbsRoomListDataFetcher
- Added change log
- Excluded room summaries without notifications from unread list
Codecov Report
@@ Coverage Diff @@
## gil/6079-Delight_Edit_layout_experiment #1540 +/- ##
============================================================================
- Coverage 42.09% 12.01% -30.08%
============================================================================
Files 515 515
Lines 84101 84115 +14
Branches 37059 35921 -1138
============================================================================
- Hits 35399 10109 -25290
- Misses 47672 73634 +25962
+ Partials 1030 372 -658
Continue to review full report at Codecov.
|
Base automatically changed from
gil/6079-Delight_Edit_layout_experiment
to
develop
August 2, 2022 15:26
…up_in_unread_tab # Conflicts: # MatrixSDK/Data/MXRoomSummary.m
gileluard
deleted the
gil/6511-Rooms_without_unread_badge_show_up_in_unread_tab
branch
13027776717
added a commit
to 13027776717/matrix-ios-sdk
that referenced
this pull request
Aug 29, 2022
* release/nodefy_0.23.15: (175 commits) finish version++ version++ Stop using the room ID from the space child state. finish version++ version++ MXBeaconAggregations: Add debug log when MXBeaconInfoSummary associated to a stopped beacon info is not found. Implement new space selector bottom sheet (matrix-org#1541) Rooms without an unread badge show up in "unread" tab (matrix-org#1540) Delight edit layout experiment (matrix-org#1515) Send an empty dictionary when calling /join to be spec compliant. Empty commit to wake codecov AllWorkingTests: Disable tests that do not pass on GH actions changelog AllWorkingTests: Disabled commented tests Crypto tests CI: Expose tests report on failure and share code coverage Tests: Run working integration tests on every PR AllWorkingTests: Disable all unit tests AllWorkingTests: Disable the 22 tests that fail AllWorkingTests: Disable test classes with tests that crash Tests: Create AllWorkingTests test plan with stable tests ... # Conflicts: # MatrixSDK/Data/RoomSummaryStore/CoreData/Models/MXRoomSummaryMO.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves element-hq/element-ios#6511