-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delight edit layout experiment #1515
Conversation
- First implementation
Codecov Report
@@ Coverage Diff @@
## develop #1515 +/- ##
============================================
+ Coverage 12.03% 42.11% +30.08%
============================================
Files 514 515 +1
Lines 83966 84101 +135
Branches 35849 37056 +1207
============================================
+ Hits 10105 35419 +25314
+ Misses 73493 47651 -25842
- Partials 368 1031 +663
Continue to review full report at Codecov.
|
- Apply search query to the recents section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, some minor comments inline. What this PR is missing however is a changelog :)
MatrixSDK/Data/RoomList/Common/MXRecentsRoomListDataFetcher.swift
Outdated
Show resolved
Hide resolved
MatrixSDK/Data/RoomList/Common/MXRecentsRoomListDataFetcher.swift
Outdated
Show resolved
Hide resolved
- update after code review
- Changed MXRecentsRoomListDataFetcher to MXBreadcrumbsRoomListDataFetcher
- Added change log
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😎
* release/nodefy_0.23.15: (175 commits) finish version++ version++ Stop using the room ID from the space child state. finish version++ version++ MXBeaconAggregations: Add debug log when MXBeaconInfoSummary associated to a stopped beacon info is not found. Implement new space selector bottom sheet (matrix-org#1541) Rooms without an unread badge show up in "unread" tab (matrix-org#1540) Delight edit layout experiment (matrix-org#1515) Send an empty dictionary when calling /join to be spec compliant. Empty commit to wake codecov AllWorkingTests: Disable tests that do not pass on GH actions changelog AllWorkingTests: Disabled commented tests Crypto tests CI: Expose tests report on failure and share code coverage Tests: Run working integration tests on every PR AllWorkingTests: Disable all unit tests AllWorkingTests: Disable the 22 tests that fail AllWorkingTests: Disable test classes with tests that crash Tests: Create AllWorkingTests test plan with stable tests ... # Conflicts: # MatrixSDK/Data/RoomSummaryStore/CoreData/Models/MXRoomSummaryMO.swift
needed for element-hq/element-ios#6079, element-hq/element-ios#6406, element-hq/element-ios#6407, element-hq/element-ios#6409