Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delight edit layout experiment #1515

Merged
merged 12 commits into from
Aug 2, 2022

Conversation

gileluard
Copy link
Contributor

@gileluard gileluard commented Jul 6, 2022

@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2022

Codecov Report

Merging #1515 (9c80cbb) into develop (840771e) will increase coverage by 30.08%.
The diff coverage is 8.72%.

@@             Coverage Diff              @@
##           develop    #1515       +/-   ##
============================================
+ Coverage    12.03%   42.11%   +30.08%     
============================================
  Files          514      515        +1     
  Lines        83966    84101      +135     
  Branches     35849    37056     +1207     
============================================
+ Hits         10105    35419    +25314     
+ Misses       73493    47651    -25842     
- Partials       368     1031      +663     
Impacted Files Coverage Δ
...RoomList/Common/MXRecentsRoomListDataFetcher.swift 0.00% <0.00%> (ø)
MatrixSDK/MXRestClient.m 45.60% <ø> (+43.11%) ⬆️
MatrixSDK/MXSession.m 47.79% <3.44%> (+40.00%) ⬆️
...mList/CoreData/MXCoreDataRoomListDataManager.swift 48.38% <33.33%> (-1.62%) ⬇️
.../RoomList/MXStore/MXStoreRoomListDataManager.swift 45.45% <33.33%> (-1.92%) ⬇️
.../Data/RoomList/Common/MXRoomListDataSortable.swift 79.06% <50.00%> (-2.99%) ⬇️
...mList/CoreData/MXCoreDataRoomListDataFetcher.swift 59.71% <50.00%> (-0.12%) ⬇️
MatrixSDK/Data/MXRoomSummary.m 64.13% <100.00%> (+56.38%) ⬆️
...DK/Data/RoomList/MXRoomListDataFilterOptions.swift 100.00% <100.00%> (ø)
...xSDK/Data/RoomList/MXRoomListDataSortOptions.swift 100.00% <100.00%> (ø)
... and 263 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 840771e...9c80cbb. Read the comment docs.

@gileluard gileluard marked this pull request as ready for review July 27, 2022 12:24
@gileluard gileluard requested a review from pixlwave July 27, 2022 12:51
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, some minor comments inline. What this PR is missing however is a changelog :)

@gileluard gileluard requested a review from pixlwave August 1, 2022 15:31
- Changed MXRecentsRoomListDataFetcher to MXBreadcrumbsRoomListDataFetcher
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😎

@gileluard gileluard merged commit b608e5f into develop Aug 2, 2022
@gileluard gileluard deleted the gil/6079-Delight_Edit_layout_experiment branch August 2, 2022 15:26
13027776717 added a commit to 13027776717/matrix-ios-sdk that referenced this pull request Aug 29, 2022
* release/nodefy_0.23.15: (175 commits)
  finish version++
  version++
  Stop using the room ID from the space child state.
  finish version++
  version++
  MXBeaconAggregations: Add debug log when MXBeaconInfoSummary associated to a stopped beacon info is not found.
  Implement new space selector bottom sheet (matrix-org#1541)
  Rooms without an unread badge show up in "unread" tab (matrix-org#1540)
  Delight edit layout experiment (matrix-org#1515)
  Send an empty dictionary when calling /join to be spec compliant.
  Empty commit to wake codecov
  AllWorkingTests: Disable tests that do not pass on GH actions
  changelog
  AllWorkingTests: Disabled commented tests
  Crypto tests CI: Expose tests report on failure and share code coverage
  Tests: Run working integration tests on every PR
  AllWorkingTests: Disable all unit tests
  AllWorkingTests: Disable the 22 tests that fail
  AllWorkingTests: Disable test classes with tests that crash
  Tests: Create AllWorkingTests test plan with stable tests
  ...

# Conflicts:
#	MatrixSDK/Data/RoomSummaryStore/CoreData/Models/MXRoomSummaryMO.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants