Handle +m by setting events_default to 1 (and back to 0 on -m) #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This only works if `modePowerMap` has values >0 set for `v`, `o`, etc. - This currently doesn't work for IRC users, as the virtual matrix user does not have power in the room because we do not bridge power level for those users. See #385. Other than that, it seems to be working as intended.
…l prefix Currently doesn't do anything as onMode bails out with "no client" since it's an IRC user.
And is required to fix #453, which is now working.
This was referenced Jun 28, 2017
lukebarnard1
reviewed
Jul 3, 2017
| const roomId = matrixRooms[i].getId(); | ||
| try { | ||
| const plContent = yield botClient.getStateEvent(roomId, "m.room.power_levels", ""); | ||
| plContent.events_default = enabled ? 1 : 0; |
There was a problem hiding this comment.
could plContent be undefined ?
There was a problem hiding this comment.
No, Synapse should make sure that every room has a m.room.power_levels event, and you can't delete state. The CS API states it'll 404 if the event doesn't exist which will throw instead of returning undefined.
There was a problem hiding this comment.
The CS API states it'll 404 if the event doesn't exist which will throw instead of returning undefined.
Ah ok, then no worries
lib/irc/IrcEventBroker.js
Outdated
| req, server, createUser(name.nick), name.chan, "names" | ||
| )); | ||
| if (!name.opLevel || name.opLevel === "") { |
There was a problem hiding this comment.
But !"" === true so name.opLevel === "" feels redundant.
lukebarnard1
approved these changes
Jul 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for this to work, I also needed to fix #385 so that real IRC users can send into moderated Matrix rooms.
Fixes #453.