Remove platformCodeName super property, and use existing appPlatform instead
#106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillCarsonFr
changed the title
|
I think this reverts #104? |
richvdh
changed the title
platformCodeName super property, and use existing appPlatform instead
BillCarsonFr
force-pushed
the
valere/remove_platformcode_use_existing
branch
from
3812b0c to
2e7ddec
Compare
yes updated PR description |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #105 as the existing Values for appPlatform have white spaces
Remove
platformCodeNameand reuseappPlatformhas now we can have enum values with whitespace.Reverts #104 and adding the new needed enum values as per https://github.com/element-hq/crypto-internal/issues/316
First commit has the schema changes. The other one is just running the script to generate the updated swift/kotlin files