-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new platform code super property #104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
@@ -38,6 +38,10 @@ data class SuperProperties( | |||
* Version of the crypto backend. | |||
*/ | |||
val cryptoSDKVersion: String? = null, | |||
/** | |||
* Used as a discriminant to breakdown usage per client. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
break down
I have to say that having two properties that do the same thing seems like a very bad idea. Can't we just fix the script? At the very least, the comments should say how the new property differs from the old one, and which we should be using in future. |
Yes fixing the script would be better. But given that the existing |
Well, could you at least add a comment to |
Fixes https://github.com/element-hq/crypto-internal/issues/316
Unfortunately I cannot just use the existing app platform, because it uses values with white space (Web Platform). The script we use to generate swift/kotlin enum will generate invalid code for such values.
We are using some custom python script to convert, not sure if worth finding how to fix them