Disables auto sanitizing for Annotation API #22562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Improve type hinting for Annotation API and limit message to 255 chars * shorten message to 255 chars * adjust tests * updates expected UI test file * cs
11 tasks
|
@sgiehl some of the UI test failures are relevant, at least https://builds-artifacts.matomo.org/matomo-org/matomo/apply330596d/10736579761/UIIntegrationTest_api_listing.png. Not sure if some other tests need adjusting, too. |
|
Didn't consider it worth the effort, as there are so many tests failing and we likely won't fix them on this branch anyway. The PR that was merged into 5.x-dev had fixed tests though and we won't merge back the changes from |
michalkleiner
approved these changes
Sep 7, 2024
sgiehl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Cheery picks #22552 for patch release
Review