Disables auto sanitizing for Annotation API #22552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
Needs Review
caddoo
approved these changes
Sep 5, 2024
sgiehl
added a commit
that referenced
this pull request
Sep 6, 2024
* Improve type hinting for Annotation API and limit message to 255 chars * shorten message to 255 chars * adjust tests * updates expected UI test file * cs
11 tasks
sgiehl
added a commit
that referenced
this pull request
Sep 7, 2024
* Disables auto sanitizing for Annotation API (#22552) * Improve type hinting for Annotation API and limit message to 255 chars * shorten message to 255 chars * adjust tests * updates expected UI test file * cs * updates expected UI test file
valentinab25
pushed a commit
to valentinab25/matomo
that referenced
this pull request
Jan 27, 2025
* Improve type hinting for Annotation API and limit message to 255 chars * shorten message to 255 chars * adjust tests * updates expected UI test file * cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR disables auto sanitizing for the Annotation API and adds a lot of type hinting to ensure the parameters have the correct type.
The note of an annotation is still sanitized manually before it is stored.
When migrating the annotations into a new database table, we should consider removing that and add a sanitizing on output instead. refs #19306
In addition this PR limits the annotation note to 255 chars, so we can easily migrate that to a VARCHAR column later.
Review