-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added back real device model in user agent feature #330
Conversation
Hey @hcbarry, thanks for the PR! Looks straight forward. |
@brototyp sure! but I'm not seeing the restart build button, which may because of the permission setting, please just restart the build :) |
Oh, dang. I can't see it either. I thought that's because it's a PR from your repository. Can you have a look if you have a button in the "More Options" menu? If that doesn't work, I guess we need to add a dummy commit 🤔 |
|
Weird! Thanks for checking that! |
Generated by 🚫 Danger |
Hmm it's strange that all tests passed on my machine but failed on travis, I'm triggering another build to see if there's a different result |
Hm. It might be some outdated Travis Setup. I'll have a look later. |
Very much appreciated! |
…ture matomo-org#253, which was removed in matomo-org#308
Finally passed 🎉🎉🎉 |
Thanks for your effort! |
I'll release this as part of the next release. |
There was a feature replacing generic string in the user agent with the real device model (#253), which was removed in WKWebView migration (#308). It would be great to have it back if possible :)