Replaced generic phone model by device model #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For android devices we see the specific device model in the backend, for iOS devices we only see generic "iPad" or "iPhone". Here we replace the generic string in the user agent with the real device model (e.g. iPhone8,4), which lets the backend properly display "iPhone SE".
|
Hi @Pe-te, thanks a lot for this PR. This isn't a method that came in mind, but it's a great idea! |
|
I love it! Looks great! Can you do me a favor and add an entry to the CHANGELOG.md? Feel free to reference yourself there. |
brototyp
approved these changes
Jun 20, 2018
|
Thanks a lot! I will wait for the tests to finish (just to make sure everything works well 😊) and will merge. |
|
Thx! If it ever causes trouble, maybe there's a cleaner way, where you add the model as extra parameter in the brackets, but this works for us right now. |
hcbarry
pushed a commit
to hcbarry/matomo-sdk-ios
that referenced
this pull request
Feb 11, 2020
…-org#253, which was removed in matomo-org#308
hcbarry
pushed a commit
to hcbarry/matomo-sdk-ios
that referenced
this pull request
Feb 11, 2020
…-org#253, which was removed in matomo-org#308
This was referenced Feb 11, 2020
hcbarry
pushed a commit
to hcbarry/matomo-sdk-ios
that referenced
this pull request
Mar 2, 2020
…-org#253, which was removed in matomo-org#308
hcbarry
pushed a commit
to hcbarry/matomo-sdk-ios
that referenced
this pull request
Mar 2, 2020
…ture matomo-org#253, which was removed in matomo-org#308
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For android devices we see the specific device model in the backend, for iOS devices we only see generic "iPad" or "iPhone".
Here we replace the generic string in the user agent with the real device model (e.g. iPhone8,4), which lets the backend properly display "iPhone SE".