Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few issues with git renames handling #79

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Conversation

matiasb
Copy link
Owner

@matiasb matiasb commented May 27, 2021

Supersedes #76 and fixes both issues described in #77.

@krobelus
Copy link

Looks good, thanks.

Looking at Git's diff_set_mnemonic_prefix, they sometimes set different prefixes instead of a/ and b/, for example in git status -vv. The full list should be 12abciow, though I don't know if there's a real use case that would benefit from that..

@matiasb
Copy link
Owner Author

matiasb commented Jun 1, 2021

Looking at Git's diff_set_mnemonic_prefix, they sometimes set different prefixes instead of a/ and b/, for example in git status -vv. The full list should be 12abciow, though I don't know if there's a real use case that would benefit from that..

That's good to know. Making the changes to support the different variations will require additional work in several places (there is code already assuming a/ and b/ prefixes). Adding an issue (#81) to track and eventually handle this

@matiasb matiasb merged commit 94e5faf into master Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants