Fix bug when processing diff with multiple renames. #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameswalmsley
force-pushed
the
fix-recursive-renames
branch
from
7ba84ab to
a684e89
Compare
jameswalmsley
force-pushed
the
fix-recursive-renames
branch
from
a684e89 to
f410d96
Compare
|
Updated tests.. awaiting feedback. |
|
Thanks for the report and fix! I'll take a look in the coming days 👍 |
matiasb
reviewed
Mar 8, 2021
| self.assertEqual(patch.added, 1) | ||
| self.assertEqual(patch.removed, 1) | ||
|
|
||
| self.assertEqual(len(res.modified_files), 4) |
There was a problem hiding this comment.
Hmm... shouldn't this be 2? Also I would expect we have 2 patch entries in res, right?
There was a problem hiding this comment.
I was wondering about this.
Currently the parser treats the renames as separate patches (with the fix I provided).
This behaviour works for my purposes, but I don't know what the real behaviour of the library should actually be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I found a bug, where diff's with multiple renames cause the "patchInfo" to be appended for each rename.
So each sucessive rename has its rename, plus all previous renames.
The diff I had the problem with is confidential, so I haven't created a test-case.
When you see the error, it should be obvious.
In anycase let me know if you want me to re-create another diff with the same issue.
Best
James