Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning when jobflow.yaml is blank or badly formatted #415

Merged
merged 5 commits into from
Aug 31, 2023

Conversation

mcgalcode
Copy link
Contributor

Summary

Addresses #411, and adds moto as a testing dependency.

Additional dependencies introduced (if any)

  • moto is added as a test dependency, but this is because it is already used in a test in tests/core/test_store.py

Checklist

Work-in-progress pull requests are encouraged, but please put [WIP] in the pull request
title.

Before a pull request can be merged, the following items must be checked:

  • Code is in the standard Python style.
    The easiest way to handle this is to run the following in the correct sequence on
    your local machine. Start with running black on your new code. This will
    automatically reformat your code to PEP8 conventions and removes most issues. Then run
    pycodestyle, followed by flake8.
  • Tests have been added for any new functionality or bug fixes.
  • All linting and tests pass.

Note that the CI system will run all the above checks. But it will be much more
efficient if you already fix most errors prior to submitting the PR. It is highly
recommended that you use the pre-commit hook provided in the repository. Simply
cp pre-commit .git/hooks and a check will be run prior to allowing commits.

@mcgalcode mcgalcode changed the title Add moto as a testing requirement Add warning when jobflow.yaml is blank or badly formatted Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #415 (ee1e109) into main (1647e53) will not change coverage.
Report is 4 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #415   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        19           
  Lines         1502      1508    +6     
  Branches       376       412   +36     
=========================================
+ Hits          1502      1508    +6     
Files Changed Coverage Δ
src/jobflow/settings.py 100.00% <100.00%> (ø)

Copy link
Member

@utf utf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much. Only thing is why the test isn't actually catching the value error.

src/jobflow/settings.py Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@utf
Copy link
Member

utf commented Aug 31, 2023

Thanks very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants