Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A blank but present ~/.quacc.yaml file causes a pydantic error #841

Closed
Andrew-S-Rosen opened this issue Sep 1, 2023 · 0 comments · Fixed by #813
Closed

A blank but present ~/.quacc.yaml file causes a pydantic error #841

Andrew-S-Rosen opened this issue Sep 1, 2023 · 0 comments · Fixed by #813
Labels
bug Something isn't working good-first-issue

Comments

@Andrew-S-Rosen
Copy link
Member

Andrew-S-Rosen commented Sep 1, 2023

We can implement a solution similar to materialsproject/jobflow#415, although there are other options too. I'm thinking a blank file should just be assumed to not override any defaults.

@Andrew-S-Rosen Andrew-S-Rosen added bug Something isn't working good-first-issue and removed bug Something isn't working labels Sep 1, 2023
Andrew-S-Rosen added a commit that referenced this issue Sep 4, 2023
Closes #811. Closes #841.

---------

Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good-first-issue
Development

Successfully merging a pull request may close this issue.

1 participant