Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate enums in Github Actions #1095

Merged
merged 14 commits into from
Sep 19, 2024
Merged

Generate enums in Github Actions #1095

merged 14 commits into from
Sep 19, 2024

Conversation

tschaume
Copy link
Member

@esoteric-ephemera @tsmathis Regenerating the enums removes the _missing_ classmethod for the VASP calc types. Is that being used/needed anywhere?

@tschaume tschaume self-assigned this Sep 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.54%. Comparing base (a6c86e0) to head (ee7f39d).
Report is 4 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (a6c86e0) and HEAD (ee7f39d). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (a6c86e0) HEAD (ee7f39d)
6 2
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1095       +/-   ##
===========================================
- Coverage   90.18%   72.54%   -17.65%     
===========================================
  Files         147       77       -70     
  Lines       14174     5059     -9115     
===========================================
- Hits        12783     3670     -9113     
+ Misses       1391     1389        -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsmathis
Copy link
Collaborator

I'm not seeing the use of __missing__ anywhere in emmet

@tsmathis
Copy link
Collaborator

I'll also close #1094 in favor of this

@tsmathis
Copy link
Collaborator

I'm not seeing the use of __missing__ anywhere in emmet

sorry, that's _missing_ actually isn't it. But same thing, non-existent as far as I can tell

@tschaume tschaume removed the request for review from esoteric-ephemera September 10, 2024 23:47
@esoteric-ephemera
Copy link
Collaborator

esoteric-ephemera commented Sep 12, 2024

@tschaume, _missing_ is needed for case insensitivity, see this issue that @munrojm fixed a while ago. Without _missing_, pydantic throws validation errors (checked for that specific MPID in the issue, mp-2048877), adding it back resolves them

_missing_ is a fallback search method for Enum's

I'd like to take a crack at having the action generate a yaml file, and instantiating the enums from yaml. I'll make a separate PR for that

@tsmathis tsmathis force-pushed the generate_enums branch 4 times, most recently from 91f51c5 to 35105fb Compare September 18, 2024 18:21
esoteric-ephemera and others added 3 commits September 18, 2024 11:22
centralize to enum generation to dev_scripts
standardize yaml config names
@tsmathis tsmathis force-pushed the generate_enums branch 5 times, most recently from 7359562 to 1807747 Compare September 18, 2024 21:49
@tsmathis tsmathis force-pushed the generate_enums branch 2 times, most recently from 1ad70df to 7bfc2a2 Compare September 18, 2024 22:58
@tsmathis tsmathis merged commit a5c9661 into main Sep 19, 2024
@tsmathis tsmathis deleted the generate_enums branch September 19, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants