Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typing in EmmetSettings #1094

Closed
wants to merge 1 commit into from
Closed

Conversation

tsmathis
Copy link
Collaborator

@tsmathis tsmathis commented Sep 10, 2024

pydantic plus python 3.10 did not like dict type annotations, switched to Dict

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.66%. Comparing base (436566d) to head (cf2e84f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1094   +/-   ##
=======================================
  Coverage   72.66%   72.66%           
=======================================
  Files          77       77           
  Lines        5015     5015           
=======================================
  Hits         3644     3644           
  Misses       1371     1371           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsmathis
Copy link
Collaborator Author

superseded by #1095

@tsmathis tsmathis closed this Sep 10, 2024
@tschaume tschaume deleted the emmet-settings-typing branch September 10, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants