Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] fixing errors in pydantic V2 implementation #566

Merged
merged 6 commits into from
Oct 13, 2023

Conversation

hrushikesh-s
Copy link
Collaborator

No description provided.

@hrushikesh-s
Copy link
Collaborator Author

@Zhuoying, only 1 test is failing here.

=========================== short test summary info ============================
FAILED tests/common/schemas/test_cclib.py::test_cclib_taskdoc - KeyError: 'test'
====== 1 failed, 135 passed, 1 skipped, 33 warnings in 424.24s (0:07:04) =======

@Zhuoying
Copy link
Contributor

@hrushikesh-s Which version of emmet here?
I suppose before v0.70.0, there were only 1 or 2 errors; after the update to v0.70.0 (fix entry=None), there are 32 errors.
Isn't that what we are trying to solve now?

@hrushikesh-s
Copy link
Collaborator Author

The CI is installing emmet-core=0.70.0 in this branch.
See here for exact details

@hrushikesh-s Which version of emmet here? I suppose before v0.70.0, there were only 1 or 2 errors; after the update to v0.70.0 (fix entry=None), there are 32 errors. Isn't that what we are trying to solve now?

@Zhuoying
Copy link
Contributor

@hrushikesh-s I see why the error numbers are different here and as in #548.
Your base branch is pydantic2 here while in #548, the base is main.

@Zhuoying
Copy link
Contributor

Close for it is a duplicate PR.

@Zhuoying Zhuoying closed this Oct 13, 2023
@Zhuoying Zhuoying reopened this Oct 13, 2023
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

❗ No coverage uploaded for pull request base (pydantic2@12f88f0). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff              @@
##             pydantic2     #566   +/-   ##
============================================
  Coverage             ?   75.36%           
============================================
  Files                ?       77           
  Lines                ?     6677           
  Branches             ?      986           
============================================
  Hits                 ?     5032           
  Misses               ?     1340           
  Partials             ?      305           

@Zhuoying Zhuoying merged commit e4eedbc into materialsproject:pydantic2 Oct 13, 2023
13 checks passed
@utf utf added the fix Bug fix PR label Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants