Skip to content

Commit

Permalink
bump lobsterpy==0.3.2 and fix TypeError: Analysis.__init__() got an u…
Browse files Browse the repository at this point in the history
…nexpected keyword argument 'whichbonds'
  • Loading branch information
janosh committed Oct 12, 2023
1 parent 7539973 commit 302bed8
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ amset = ["amset>=0.4.15", "pydash"]
cclib = ["cclib"]
mp = ["mp-api>=0.37.5"]
phonons = ["phonopy>=1.10.8", "seekpath"]
lobster = ["lobsterpy>=0.3.1"]
lobster = ["lobsterpy>=0.3.2"]
defects = ["dscribe>=1.2.0", "pymatgen-analysis-defects>=2022.11.30"]
forcefields = ["chgnet>=0.2.2", "matgl>=0.8.3", "quippy-ase>=0.9.14"]
docs = [
Expand All @@ -68,7 +68,7 @@ strict = [
"dscribe==2.1.0",
"emmet-core==0.70.0",
"jobflow==0.1.14",
"lobsterpy==0.3.1",
"lobsterpy==0.3.2",
"matgl==0.8.3",
"monty==2023.9.25",
"mp-api==0.37.5",
Expand Down
6 changes: 3 additions & 3 deletions src/atomate2/lobster/schemas.py
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ def from_directory(
path_to_charge=charge_path,
summed_spins=False, # we will always use spin polarization here
cutoff_icohp=0.10,
whichbonds=which_bonds,
which_bonds=which_bonds,
)
cba_run_time = time.time() - start
# initialize lobsterpy condensed bonding analysis
Expand Down Expand Up @@ -262,7 +262,7 @@ def from_directory(
cohp_plot_data=cba_cohp_plot_data,
cutoff_icohp=analyse.cutoff_icohp,
summed_spins=False,
which_bonds=analyse.whichbonds,
which_bonds=analyse.which_bonds,
final_dict_bonds=analyse.final_dict_bonds,
final_dict_ions=analyse.final_dict_ions,
run_time=cba_run_time,
Expand Down Expand Up @@ -683,7 +683,7 @@ def _identify_strongest_bonds(
are_cobis=are_cobis,
are_coops=are_coops,
strongest_bonds=bond_dict,
which_bonds=analyse.whichbonds,
which_bonds=analyse.which_bonds,
)
)
else:
Expand Down

0 comments on commit 302bed8

Please sign in to comment.