Ruff #250
Merged
Ruff #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
==========================================
- Coverage 75.39% 75.31% -0.09%
==========================================
Files 55 55
Lines 4723 4707 -16
Branches 692 682 -10
==========================================
- Hits 3561 3545 -16
- Misses 975 982 +7
+ Partials 187 180 -7
|
|
This looks great, but could you fix the failing linting? |
|
Definitely. Just wanted to hear your feedback first. |
|
Awesome thank you. Ruff looks excellent! I'll have to switch to it on all my projects |
janosh
commented
Feb 23, 2023
janosh
commented
Feb 23, 2023
That's what I did. 😄 And certainly didn't regret it. The speed is incredible as is the number of linting rules it provides! |
janosh
commented
Feb 23, 2023
| - repo: https://github.com/pycqa/isort | ||
| rev: 5.12.0 | ||
| hooks: | ||
| - id: isort | ||
| - repo: https://github.com/pycqa/flake8 |
There was a problem hiding this comment.
We could prob replace flake8 here with ruff too. I know ruff implements these plugins since I was using those as well.
- pyproject-flake8==6.0.0
- flake8-bugbear==22.12.6
- flake8-typing-imports==1.14.0
- flake8-docstrings==1.6.0
But haven't checked these two yet:
- flake8-rst-docstrings==0.3.0
- flake8-rst==0.8.0
|
What should be E501s |
|
So I think black has the behaviour that 88 is the ideal length but if it can't make the line any shorter then it's okay to go beyond that. I think there was an option in flake-bugbear to support this behaviour: PyCQA/flake8-bugbear#54 I'm not sure if that is also available in ruff? |
|
IIUC astral-sh/ruff#389 (comment) suggests just disabling E501. Charlie decided to not support B950 for now. |
|
I went ahead and fixed the existing E501s. All but one case were easily refactored to avoid long lines and the last one I added |
refactor caused raise FileNotFoundError(f"Could not find {base_name} or {base_name}.gz file.")
FileNotFoundError: Could not find INCAR or INCAR.gz file.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #249.
Just to give an idea, this is what adding
rufflinter would look like.