Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate linting to Ruff #249

Closed
janosh opened this issue Feb 21, 2023 · 0 comments · Fixed by #250
Closed

Migrate linting to Ruff #249

janosh opened this issue Feb 21, 2023 · 0 comments · Fixed by #250

Comments

@janosh
Copy link
Member

janosh commented Feb 21, 2023

Just a suggestion but one that has worked out very well for pymatgen over in materialsproject/pymatgen#2847: we could migrate linting of atomate2 to ruff.

Ruff combines the functionality of most other Python linters into 1 tool written in Rust which makes it ~100x faster than linters written in Python. It brought the pymatgen linting CI script's run time from 9 min down to 3 min (almost entirely spent installing deps and running mypy now, ruff itself only takes 1 sec).

Happy to take this on if interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant