Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Always add the toView to the container. #68

Merged
merged 1 commit into from
Jun 26, 2019
Merged

Always add the toView to the container. #68

merged 1 commit into from
Jun 26, 2019

Conversation

jverkoey
Copy link
Contributor

@jverkoey jverkoey commented Jun 26, 2019

On iOS 13, the to view for default transitions has changed from the view controller to a container view.

Prior to this change, this meant that our transitions would not add the "to" view to the view hierarchy, resulting in the transition getting in to a confusing visual state.

After this change, we always add the "to" view to the view hierarchy if it does not already have a parent.

Repro steps:

  1. Open the catalog on an iOS 13 simulator/device.
  2. Open the contextual transition example.
  3. Tap the blue square.

Expected behavior: the transition completes, showing a pink view controller.

Actual behavior: the transition never appears to complete, and no pink view controller is shown.

Before After
Simulator Screen Shot - iPhone Xʀ - 2019-06-26 at 07 54 02 Simulator Screen Shot - iPhone Xʀ - 2019-06-26 at 07 53 21

On iOS 13, the to view for default transitions has changed from the view controller to a container view.

Prior to this change, this meant that our transitions would not add the "to" view to the view hierarchy, resulting in the transition getting in to a confusing visual state.

After this change, we always add the "to" view to the view hierarchy if it does not already have a parent.
@jverkoey jverkoey requested a review from codeman7 June 26, 2019 11:40
@jverkoey jverkoey merged commit 0a9568b into develop Jun 26, 2019
@jverkoey jverkoey deleted the always branch June 26, 2019 12:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants