This repository has been archived by the owner on Aug 30, 2023. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Always add the toView to the container. (#68)
On iOS 13, the to view for default transitions has changed from the view controller to a container view. Prior to this change, this meant that our transitions would not add the "to" view to the view hierarchy, resulting in the transition getting in to a confusing visual state. After this change, we always add the "to" view to the view hierarchy if it does not already have a parent. Repro steps: 1. Open the catalog on an iOS 13 simulator/device. 2. Open the contextual transition example. 3. Tap the blue square. Expected behavior: the transition completes, showing a pink view controller. Actual behavior: the transition never appears to complete, and no pink view controller is shown. | Before | After | |:----|:----| | ![Simulator Screen Shot - iPhone Xʀ - 2019-06-26 at 07 54 02](https://user-images.githubusercontent.com/45670/60177728-a439c600-97e7-11e9-8dea-39aecfd25ffe.png) | ![Simulator Screen Shot - iPhone Xʀ - 2019-06-26 at 07 53 21](https://user-images.githubusercontent.com/45670/60177723-9edc7b80-97e7-11e9-8c9f-08bf6f33dc3c.png) |
- Loading branch information