-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto bump MDC Web deps to 5.0.0-canary.a5dbd8a2a.0 #676
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
@aomarks where is the CI for these? |
Heh, I was just looking into this yesterday. Turns out PRs created by GitHub Actions don't trigger other GitHub Actions, it's a deliberate limitation to prevent bad loops. peter-evans/create-pull-request#48 explains it, and gives a solution, which is to get a personal access token from some account, put it in the repo secrets, and use that instead of the automatic authentication it uses by default. But that means the PR will come from whoever's account the token was from. I was thinking maybe we should create a special robot github account for this purpose, or use one that already exists. |
I guess we can merge and master should trigger CI and we can revert this branch if fails? |
Yeah that's what I've been doing lately. Not ideal but not that big a deal to roll back. Also if we merge MDC/MWC repos this will be a non-issue of course. |
This PR was auto generated by the bump-mdc-deps GitHub action.