fix(slider): slider track not visible #5512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhiomkar
requested changes
Jan 23, 2020
These changes fix the following issues which were introduced by material-components#5132: 1. The background of track is now provided by `.mdc-slider__track-container::after`, however `::after` wasn't positioned correctly which made it invisible. 2. The `::after` structural styles were set inside the `color` feature target. This means that they'll end up being included multiple times and in the wrong place.
crisbeto
force-pushed
the
slider-track
branch
from
b5451fd to
9e285cb
Compare
abhiomkar
approved these changes
Jan 23, 2020
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jan 24, 2020
We recently updated to the latest MDC Canary to fix some build issues and be able to use the feature targeting for the form field, but it also came in with a regression. These changes update to a newer Canary version that has a fix for the regression (material-components/material-components-web#5512).
jelbourn
pushed a commit
to angular/components
that referenced
this pull request
Jan 25, 2020
We recently updated to the latest MDC Canary to fix some build issues and be able to use the feature targeting for the form field, but it also came in with a regression. These changes update to a newer Canary version that has a fix for the regression (material-components/material-components-web#5512).
yifange
pushed a commit
to yifange/components
that referenced
this pull request
Jan 30, 2020
We recently updated to the latest MDC Canary to fix some build issues and be able to use the feature targeting for the form field, but it also came in with a regression. These changes update to a newer Canary version that has a fix for the regression (material-components/material-components-web#5512).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes fix the following issues which were introduced by #5132:
.mdc-slider__track-container::after, however::afterwasn't positioned correctly which made it invisible.::afterstructural styles were set inside thecolorfeature target. This means that they'll end up being included multiple times and in the wrong place.Screenshot for reference:
