Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump to latest MDC Canary to fix regression #18281

Merged
merged 1 commit into from
Jan 25, 2020

Conversation

crisbeto
Copy link
Member

We recently updated to the latest MDC Canary to fix some build issues and be able to use the feature targeting for the form field, but it also came in with a regression. These changes update to a newer Canary version that has a fix for the regression (material-components/material-components-web#5512).

We recently updated to the latest MDC Canary to fix some build issues and be able to use the feature targeting for the form field, but it also came in with a regression. These changes update to a newer Canary version that has a fix for the regression (material-components/material-components-web#5512).
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent pr: merge safe target: major This PR is targeted for the next major release labels Jan 24, 2020
@crisbeto crisbeto requested review from jelbourn and a team as code owners January 24, 2020 21:34
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 24, 2020
@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 24, 2020
@jelbourn jelbourn merged commit ce40ec2 into angular:master Jan 25, 2020
yifange pushed a commit to yifange/components that referenced this pull request Jan 30, 2020
We recently updated to the latest MDC Canary to fix some build issues and be able to use the feature targeting for the form field, but it also came in with a regression. These changes update to a newer Canary version that has a fix for the regression (material-components/material-components-web#5512).
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants