shell: Respect user's toolbar-style setting

[zeldin]

Atril should respect if the user wants another toolbar-style than "both-horiz" by checking the "toolbar-style" key of the "org.mate.interface" schema in GSettings.

[monsta]

Nice - but would be better to check the existence of the schema before using it. There are people who use Atril in other desktop environments.

Also this setting is completely ignored in GTK+3 build - they made it no-op at some point... IIRC it was in GTK+ 3.10.

[zeldin]

Right you are. I run it in XFCE myself, but I still have all the MATE schemas installed. 😄
I pushed a fix to this PR.

Also this setting is completely ignored in GTK+3 build

Hm? The patch works fine for me (as in, all the styles do what they are supposed to when I set the setting) with GTK+3.20.6 on Debian stretch...

[monsta]

I recall eom ignores this setting in GTK+3 build, so I thought Atril does the same... I'll check it once more.

[monsta]

Hmm, interesting... GTK+2 build of Atril reacts to this setting even without this PR. The only issue is that "icon" value isn't processed properly - Atril uses "both" value instead. GTK+2 build of eom has the same behavior. I'll check GTK+3 build later.

[raveit65]

@monsta
What is the state of merging this PR?
Or do we need this with gtk3 build any more?

[monsta]

Ok, it works with current git master. I guess it's because we have a custom "libegg" toolbar, not some standard GTK+ one. I remember the toolbars settings were ignored in the standard one, therefore we removed them from the last tab of mate-appearance-properties...

[monsta]

GTK+2 build of Atril reacts to this setting even without this PR. The only issue is that "icon" value isn't processed properly - Atril uses "both" value instead.

Here in GTK+3 code we get the same behavior with this PR. In other words, it seems ok since it restores the old behavior. As for some values not working, I guess it's some separate issue in the toolbars.

[raveit65]

hmm, it seems to be a bit inconsistent.

• both --> text is under icons on most buttons
• icon --> i see only icons, but for forward/previous buttons i see icons and text.
• both-horz --> same as with icons

[lukefromdc]

This works as advertised with GTK 3.22.9

[monsta]

Yes, this inconsistency is what I was talking about. You can check GTK+2 build (in 1.16) and see it there as well. That's why I think it's some separate issue in the toolbars.

[raveit65]

As, this doesn't work for normal Gtk Toolbars i am in doubt that i will ever use that ;-)
I don't like to use all the old deprecated gtk+2 stuff for myself........
So feel free to merge it if you think it is OK.

[monsta]

Ok, rebased and merged.