Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Bring back toolbar-style and toolbar-icons-size support #115

Open
na0miluv opened this issue Sep 15, 2024 · 2 comments
Open

[Request] Bring back toolbar-style and toolbar-icons-size support #115

na0miluv opened this issue Sep 15, 2024 · 2 comments
Labels
help wanted patch feature request A "nice to have" patch to complement the classic experience

Comments

@na0miluv
Copy link

na0miluv commented Sep 15, 2024

What should be patched?

Previous to GTK 3.10, toolbar-style was a setting that allowed you to change the style of toolbars in applications between 4 styles.

  • both
  • both-horiz
  • icons
  • text

Alongide toolbar-style, there was also toolbar-icons-size which used to let you change the size of the toolbar icons between small and large. This also has been hard coded since GTK 3.10

A lot of distros used to ship with "both" as the default while current day distros are forced to use "both-horiz", if they even show any labels on the toolbar, and it would be nice to see it brought back.

Screenshots

Captura de pantalla -2024-09-15 07-51-15
Caja using the hard-coded both-horiz + large-icons style

Captura de pantalla -2024-09-15 07-52-06
Geany using both + small-icons style, this and Pluma are the only ones that can still be changed because of the way they implemented it.

Commits

Couldn't find an exact commit but here is the proof of the removal
https://gitlab.gnome.org/search?group_id=8&project_id=665&repository_ref=main&scope=blobs&search=toolbar-style

@na0miluv na0miluv added help wanted patch feature request A "nice to have" patch to complement the classic experience labels Sep 15, 2024
@lah7
Copy link
Owner

lah7 commented Sep 15, 2024

The good news is that this setting still exists in GTK 3.24.x, but it's hidden behind a dconf property. The proof you found removes it in GTK 4.

Install/use dconf-editor (or use dconf in a terminal) to go here:

  • /org/gnome/desktop/interface
  • /org/mate/desktop/interface

Where you'll find:

  • toolbar-icons-size
  • toolbar-style

image

Changing these settings and relaunching certain apps (like Meld) will reflect these changes. Like you noticed, apps like Geany can control the style in their own code, but thankfully Geany does offer options to change it. For MATE apps... well... that's the bad news. Looks like they don't read that setting, so it needs adding for each MATE app. Caja hasn't, but Atril did.

A patch for gtk3-classic could work, something could optionally force the toolbar style via an environment variable - pull requests welcome!

PS. What's the name of that icon theme? Looks pretty nice!

@na0miluv
Copy link
Author

For MATE apps... well... that's the bad news. Looks like they don't read that setting, so it needs adding for each MATE app.

Ah damn, well that explains why changing it on both gnome/interface and mate/interface didn't do anything.

A patch for gtk3-classic could work, something could optionally force the toolbar style via an environment variable - pull requests welcome!

I'll try making it an environment variable and see if it works, which I'm hoping it does :'(

PS. What's the name of that icon theme? Looks pretty nice!

It's RedHat's old Bluecurve theme (icons and GTK theme ported to GTK 3 and 4!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted patch feature request A "nice to have" patch to complement the classic experience
Projects
None yet
Development

No branches or pull requests

2 participants