fix: set s3_acl_enabled to false when s3_permission empty

[everpcpc]

for: #17978

A kt-paperclip upgrade is also needed, e.g. kreeti/kt-paperclip#80

[shleeable]

If this sets any kind of default. Please add it to the .env.production file

[Gargron]

What is the replacement for ACL? Setting media to private on suspension is a pretty important function.

[everpcpc]

What is the replacement for ACL? Setting media to private on suspension is a pretty important function.

there is a Bucket owner enforced mode to use policy for bucket
https://docs.aws.amazon.com/AmazonS3/latest/userguide/about-object-ownership.html

[Gargron]

Oh, so AWS is not removing support for ACL, it is a custom setting.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[everpcpc]

What is the replacement for ACL? Setting media to private on suspension is a pretty important function.

Since we usually want our s3 bucket to be private entirely and serve files via CloudFront, maybe we could change this way suspension media. For example by moving them to specific path with special bucket or CloudFront policy?

[lgE-1]

This option is also necessary for other s3 services which do not support ACLs such as Cloudflare R2.

[everpcpc]

kreeti/kt-paperclip#92
has been merge, and we need to wait for this commit release

[github-actions]

This pull request has merge conflicts that must be resolved before it can be merged.

[mjankowski]

It looks like that kt-paperclip change was merged and released in v7.2.0, which we are upgraded past now.

If this is still relevant, can you rebase? If not, close.

[everpcpc]

Seems like we can just set this option with S3_PERMISSION, update.

[github-actions]

This pull request has resolved merge conflicts and is ready for review.

[github-actions]

This pull request has merge conflicts that must be resolved before it can be merged.

[ThisIsMissEm]

This currently has a "won't fix" label, though it looks like it was automatically added — is this still something that's necessary or desired?

[mjankowski]

Based on rebase needed and sheer age - closing this. Please rebase/reopen if still relevant.

[everpcpc]

I've rebased this, but I did not see any reopen button