removed S3 acls to stop errors from aws #80
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Thimmaiah is there any article or announcement by AWS S3 regarding this? Can you please provide more details. |
|
1. If you create an S3 bucket, it clearly tells you that ACLs will not be
supported anymore
2. If you use the gem, without the changes I made, and try to upload to S3,
then it will fail and you cannot upload.
Ive forked and using it in my project.
THanks
…On Sat, Feb 5, 2022 at 11:03 PM Surendra Singhi ***@***.***> wrote:
Hi @Thimmaiah <https://github.com/thimmaiah> is there any article or
announcement by AWS S3 regarding this? Can you please provide more details.
—
Reply to this email directly, view it on GitHub
<#80 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFOFXJ4IEOAMNS7INTYB33UZVNNJANCNFSM5NR5MNRQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This was referenced Apr 7, 2022
|
Maybe we can add an option for the new policy and do not affect old bucket ACL users. |
|
@Thimmaiah this change would break backward compatibility for many applications, so it needs to be carefully thought through, and perhaps an option given to the users if they want to disable acl. |
|
@Thimmaiah please see #92 Closing this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ACLs are no longer supported for S3 buckets in aws. It throws an error if this is not commented out