Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bootstrap limits (again :) ) #4518

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

Leo-Besancon
Copy link
Collaborator

@Leo-Besancon Leo-Besancon commented Nov 6, 2023

Math behind the values:

Base message size: 110MB.
Updates allowed: 190MB.
Total message size: 300MB.
Base timeout config for 1 message: 30s
In 30s, 60 slots, if each slot filled with 10k tx, so 600 000 tx total. The max updates allowed would be of size 300 bytes on average.
One basic 100Mbps home fiber connection can send 375MB in 30s.

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@Leo-Besancon Leo-Besancon merged commit 155c1ab into securnet_wip Nov 7, 2023
@Leo-Besancon Leo-Besancon deleted the update_bootstrap_limits branch November 7, 2023 08:42
@Leo-Besancon Leo-Besancon mentioned this pull request Nov 8, 2023
45 tasks
damip pushed a commit that referenced this pull request Nov 8, 2023
* Update securnet

* add server tests (#4488)

* Implement parametric tests for bootstrap (#4454)

* Add tests for bootstrap
* Add new tests bootstrap (#4509)

Signed-off-by: Litchi Pi <[email protected]>
Co-authored-by: AurelienFT <[email protected]>

* remove testing import

* fix clippy

* Update bootstrap limits (again :) ) (#4518)

* Decrease timeouts, decrease message_size

* Update message_max_size and comment for updates

* Fix smart-contracts gas payments (#4505)

* Update packages

* Pay VM creation and compilations correctly

* Use max_instance_cost for default compilation

* Update module costs

* Minor metrics

* Tmp module metrics and high max_instance value for testing

* Calibrated costs for compilation and instance + compilation metrics cleanup

* Change costs and use runtime branch

* Add SC gas doc & improve CL compilation payments

* Update gas costs & other minor changes

* Clippy fixes

* Cargo.toml & cfg fixes

* Remove context payments and update ABI costs

* Update documentation

* Impl get_tmp_module

* Update doc

* Review updates

* Doc

* Loader documentation

* Fmt

* Remove compilation timers

* Add gas to base operation (tx, roll buy & sell)

Signed-off-by: Jean-François <[email protected]>

* Fix majority of tests

* Fix remaining tests

* Update unit test SC src tag

* Move SP compilation payment to OP and ABI costs

* Update gas documentation

* Update RuntimeModule usage, fix from_op, add sp compil to pool config, fix tests

* Update gas table doc

* Fix tests

* Add an important little bit of doc

* saturating_add on sp cost

---------

Signed-off-by: Jean-François <[email protected]>
Co-authored-by: Jean-François <[email protected]>

* Reduce block size to 300k (#4519)

* fix event filter (#4422)

* Update genesis and versions (#4523)

* fix fmt

* fix clippy

* Update securnet (#4525)

* update package version and genesis

* update lock

* Fix send_operation GRPC test

* Update mock.rs

* Change runtime target to latest main rev

* update genesis

---------

Signed-off-by: Litchi Pi <[email protected]>
Signed-off-by: Jean-François <[email protected]>
Co-authored-by: Modship <[email protected]>
Co-authored-by: Litchi Pi (Tim) <[email protected]>
Co-authored-by: AurelienFT <[email protected]>
Co-authored-by: Eitu33 <[email protected]>
Co-authored-by: Jean-François <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants