Implement parametric tests for bootstrap #4454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leo-Besancon
reviewed
Oct 9, 2023
There was a problem hiding this comment.
Nice test improvements!
A few general comments:
- Can you look at Add 4 unit tests for final state (line coverage ~ 80%) #4447 for overlaps / conflicts with your changes on final_state
- Do your tests include ser / deser at the limits (on top of randomized tests, we could manually test with data on the limit / just over the limit to see that the checks are well made)
- Another thing to uint test is the behaviour of a bootstrap server (on what conditions it can fail / panic / ...)
litchipi
force-pushed
the
bootstrap_tests
branch
2 times, most recently
from
7434ab5
to
89044be
Compare
litchipi
force-pushed
the
bootstrap_tests
branch
from
75e7b7a
to
e7bb8ee
Compare
Signed-off-by: Litchi Pi <[email protected]>
litchipi
force-pushed
the
bootstrap_tests
branch
from
a1f4df3
to
a2c49e6
Compare
Signed-off-by: Litchi Pi <[email protected]>
Signed-off-by: Litchi Pi <[email protected]>
Signed-off-by: Litchi Pi <[email protected]>
Signed-off-by: Litchi Pi <[email protected]>
AurelienFT
reviewed
Nov 6, 2023
AurelienFT
approved these changes
Nov 6, 2023
damip
pushed a commit
that referenced
this pull request
Nov 8, 2023
* Update securnet * add server tests (#4488) * Implement parametric tests for bootstrap (#4454) * Add tests for bootstrap * Add new tests bootstrap (#4509) Signed-off-by: Litchi Pi <[email protected]> Co-authored-by: AurelienFT <[email protected]> * remove testing import * fix clippy * Update bootstrap limits (again :) ) (#4518) * Decrease timeouts, decrease message_size * Update message_max_size and comment for updates * Fix smart-contracts gas payments (#4505) * Update packages * Pay VM creation and compilations correctly * Use max_instance_cost for default compilation * Update module costs * Minor metrics * Tmp module metrics and high max_instance value for testing * Calibrated costs for compilation and instance + compilation metrics cleanup * Change costs and use runtime branch * Add SC gas doc & improve CL compilation payments * Update gas costs & other minor changes * Clippy fixes * Cargo.toml & cfg fixes * Remove context payments and update ABI costs * Update documentation * Impl get_tmp_module * Update doc * Review updates * Doc * Loader documentation * Fmt * Remove compilation timers * Add gas to base operation (tx, roll buy & sell) Signed-off-by: Jean-François <[email protected]> * Fix majority of tests * Fix remaining tests * Update unit test SC src tag * Move SP compilation payment to OP and ABI costs * Update gas documentation * Update RuntimeModule usage, fix from_op, add sp compil to pool config, fix tests * Update gas table doc * Fix tests * Add an important little bit of doc * saturating_add on sp cost --------- Signed-off-by: Jean-François <[email protected]> Co-authored-by: Jean-François <[email protected]> * Reduce block size to 300k (#4519) * fix event filter (#4422) * Update genesis and versions (#4523) * fix fmt * fix clippy * Update securnet (#4525) * update package version and genesis * update lock * Fix send_operation GRPC test * Update mock.rs * Change runtime target to latest main rev * update genesis --------- Signed-off-by: Litchi Pi <[email protected]> Signed-off-by: Jean-François <[email protected]> Co-authored-by: Modship <[email protected]> Co-authored-by: Litchi Pi (Tim) <[email protected]> Co-authored-by: AurelienFT <[email protected]> Co-authored-by: Eitu33 <[email protected]> Co-authored-by: Jean-François <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more tests for
massa-bootstrapAdds everything required to perform parametric testing easily
Test edge cases using parametric testing
Based on top of #4453