Skip to content

Commit

Permalink
ui: remove link to stmt details on sessions details
Browse files Browse the repository at this point in the history
Previously, when a statment was active, it would show
on the Sessions page with a link to view its details,
but since the statement was not yet saved/persisted,
clicking the link it would crash the Statement Details
page.
This commit removes this link.

Fixes cockroachdb#84462

Release note (ui change): Removal of `View Statement Details`
link inside the Sessions Details page.
  • Loading branch information
maryliag committed Jul 15, 2022
1 parent 3c6c893 commit c563502
Showing 1 changed file with 0 additions and 21 deletions.
21 changes: 0 additions & 21 deletions pkg/ui/workspaces/cluster-ui/src/sessions/sessionDetails.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -321,27 +321,6 @@ export class SessionDetails extends React.Component<SessionDetailsProps> {
value={TimestampToMoment(stmt.start).format(DATE_FORMAT)}
className={cx("details-item")}
/>
<SummaryCardItem
label={
<div className={cx("session-details-link")}>
<Link
to={StatementLinkTarget({
statementFingerprintID: stmt.id,
statementNoConstants: stmt.sql_no_constants,
implicitTxn: session.active_txn?.implicit,
})}
onClick={() =>
this.props.onStatementClick &&
this.props.onStatementClick()
}
>
View Statement Details
</Link>
</div>
}
value={""}
className={cx("details-item")}
/>
</Col>
<Col className="gutter-row" span={4} />
<Col className="gutter-row" span={10}>
Expand Down

0 comments on commit c563502

Please sign in to comment.