Remove View Statement Details from Session Details #84462
Assignees
Labels
A-sql-observability
Related to observability of the SQL layer
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Comments
ghost
added
C-bug
craig bot
pushed a commit
that referenced
this issue
Jul 15, 2022
84406: sql: make setup of leaf txn for streamer more bullet-proof r=yuzefovich a=yuzefovich This commit makes sure that we try to use the streamer API only if we can actually create a non-nil `LeafTxn`. In some edge cases it appears that all the previous checks were insufficient, and this commit should take care of that. Note that I couldn't reproduce those edge cases manually, so there is no regression test. Fixes: #84239. Release note: None 84455: outliers: prepare for asynchronous processing r=matthewtodd a=matthewtodd Moving a few things around in advance of the real work of #81021. 84485: ui: remove link to stmt details on sessions details r=maryliag a=maryliag Previously, when a statment was active, it would show on the Sessions page with a link to view its details, but since the statement was not yet saved/persisted, clicking the link it would crash the Statement Details page. This commit removes this link. Fixes #84462 Release note (ui change): Removal of `View Statement Details` link inside the Sessions Details page. 84488: roachtest: lower descriptor lease duration in acceptance/version-upgrade r=srosenberg a=renatolabs The `acceptance/version-upgrade` test uncovered a descriptor lease leak that can lead to the test timing out due to waiting a full lease duration (5 minutes by default), making it flaky. Once the bug is fixed, we should be able to use the default duration again. Relates to #84382. Release note: None. Co-authored-by: Yahor Yuzefovich <[email protected]> Co-authored-by: Matthew Todd <[email protected]> Co-authored-by: Marylia Gutierrez <[email protected]> Co-authored-by: Renato Costa <[email protected]>
maryliag
added a commit
to maryliag/cockroach
that referenced
this issue
Jul 15, 2022
Previously, when a statment was active, it would show on the Sessions page with a link to view its details, but since the statement was not yet saved/persisted, clicking the link it would crash the Statement Details page. This commit removes this link. Fixes cockroachdb#84462 Release note (ui change): Removal of `View Statement Details` link inside the Sessions Details page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The View Statement Details link doesn't work.
When I click the link nothing happens:
Add any other context about the problem here.
Related to #70785 and #70805 .
Jira issue: CRDB-17672
The text was updated successfully, but these errors were encountered: