Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement improvements for frontend #665

Merged
merged 13 commits into from
Nov 4, 2023
Merged

Implement improvements for frontend #665

merged 13 commits into from
Nov 4, 2023

Conversation

marvinruder
Copy link
Owner

* Fix #661 User API logs error to console when not signed in
* Fix #662 Sourcemap comments are not present in some chunks
* Resolves #663 Use CSS-only background animation

Signed-off-by: Marvin A. Ruder <[email protected]>
* Rename background component

Signed-off-by: Marvin A. Ruder <[email protected]>
Signed-off-by: Marvin A. Ruder <[email protected]>
Signed-off-by: Marvin A. Ruder <[email protected]>
Signed-off-by: Marvin A. Ruder <[email protected]>
Signed-off-by: Marvin A. Ruder <[email protected]>
Signed-off-by: Marvin A. Ruder <[email protected]>
Signed-off-by: Marvin A. Ruder <[email protected]>
* Fix visual glitches related to overscroll

Signed-off-by: Marvin A. Ruder <[email protected]>
Signed-off-by: Marvin A. Ruder <[email protected]>
@marvinruder marvinruder added feature New feature or request frontend Related to frontend package backend Related to backend package commons Related to commons package performance Improvement to performance labels Nov 4, 2023
@marvinruder marvinruder self-assigned this Nov 4, 2023
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -0.10%) 100.00% (target: 100.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e2627e2) 8875 8875 100.00%
Head commit (2a5255e) 9001 (+126) 9001 (+126) 100.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#665) 194 194 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@marvinruder marvinruder merged commit b2488ec into main Nov 4, 2023
6 checks passed
@marvinruder marvinruder deleted the improve-frontend branch November 4, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend package commons Related to commons package feature New feature or request frontend Related to frontend package performance Improvement to performance
Projects
None yet
1 participant