Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CSS-only background animation #663

Closed
marvinruder opened this issue Nov 3, 2023 · 0 comments · Fixed by #665
Closed

Use CSS-only background animation #663

marvinruder opened this issue Nov 3, 2023 · 0 comments · Fixed by #665
Assignees
@marvinruder
Labels
backend Related to backend package commons Related to commons package feature New feature or request frontend Related to frontend package performance Improvement to performance

Comments

@marvinruder
Copy link
Owner

Is your feature request related to a problem? Please describe.
JavaScript-based animations are CPU-intensive, block the main thread and impact page performance especially on mobile devices.

Describe the solution you’d like
A background animation using only CSS animations with no JavaScript-based computations. Ideally, the background consists of visual elements related to the Rating Tracker, such as stock logos.

Describe alternatives you’ve considered

  • Current background (bad performance)
  • Plain background (boring)
@marvinruder marvinruder added feature New feature or request frontend Related to frontend package backend Related to backend package commons Related to commons package performance Improvement to performance labels Nov 3, 2023
@marvinruder marvinruder self-assigned this Nov 3, 2023
marvinruder added a commit that referenced this issue Nov 3, 2023
@marvinruder
Implement improvements for frontend
abbcb17 
* Fix #661 User API logs error to console when not signed in
* Fix #662 Sourcemap comments are not present in some chunks
* Resolves #663 Use CSS-only background animation

Signed-off-by: Marvin A. Ruder <[email protected]>
marvinruder added a commit that referenced this issue Nov 4, 2023
@marvinruder
Implement improvements for frontend
57b0db7 
* Fix #661 User API logs error to console when not signed in
* Fix #662 Sourcemap comments are not present in some chunks
* Resolves #663 Use CSS-only background animation

Signed-off-by: Marvin A. Ruder <[email protected]>
@marvinruder marvinruder mentioned this issue Nov 4, 2023
Merged
marvinruder added a commit that referenced this issue Nov 4, 2023
@marvinruder
Implement improvements for frontend (#665)
b2488ec 
* Fix #661 User API logs error to console when not signed in
* Fix #662 Sourcemap comments are not present in some chunks
* Resolve #663 Use CSS-only background animation
* Change background effect of login card
* Reorganize frontend files 
* Fix visual glitches related to overscroll
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marvinruder marvinruder

Labels
backend Related to backend package commons Related to commons package feature New feature or request frontend Related to frontend package performance Improvement to performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement improvements for frontend marvinruder/rating-tracker
1 participant
@marvinruder