Remove deprecated props

docs/ListTutorial.md

@@ -825,7 +825,6 @@ The [`<Pagination>`](./Pagination.md) component gets the following constants fro
 * `hasPreviousPage`: True if the page number is greater than 1.
 * `hasNextPage`: True if the page number is lower than the total number of pages.
 * `actions`: A component that displays the pagination buttons (default: `<PaginationActions>`)
-* `limit`: An element that is displayed if there is no data to show (default: `<PaginationLimit>`)
 
 If you want to replace the default pagination by a "&lt; previous - next &gt;" pagination, create a pagination component like the following:
 

docs/Upgrade.md

@@ -924,6 +924,93 @@ The `<InputHelperText>` component no longer accepts a `touched` prop. This prop
 
 If you were using this prop, you can safely remove it.
 
+## `useCheckAuth` No Longer Accepts A `disableNotification` Param
+
+The `useCheckAuth` hook no longer accepts the deprecated `disableNotification` param. To disable the "Authentication required" notification when calling `checkAuth`, `authProvider.checkAuth()` should return a rejected promise with the value `{ message: false }`:
+
+```ts
+const authProvider: AuthProvider = {
+    //...
+    checkAuth: () => Promise.reject({ message: false }),
+}
+```
+
+## `useLogoutIfAccessDenied` No Longer Accepts A `disableNotification` Param
+
+The `useLogoutIfAccessDenied` hook no longer accepts the deprecated `disableNotification` param. To disable the "Authentication required" notification when `checkError` is called, `authProvider.checkError()` should return a rejected promise with the value `{ message: false }`:
+
+```ts
+const authProvider: AuthProvider = {
+    //...
+    checkError: () => Promise.reject({ message: false }),
+}
+```
+
+Or the `useLogoutIfAccessDenied` hook could be called with an error param as follows:
+
+```ts
+const logoutIfAccessDenied = useLogoutIfAccessDenied();
+logoutIfAccessDenied(new Error('Denied'));
+```
+## `onError` Type From `ra-core` Was Removed
+
+The `onError` type from `ra-core` was removed. Use `OnError` instead.
+
+## `linkToRecord` Helper Was Removed
+
+The `linkToRecord` helper was removed. Use [`useCreatePath`](https://marmelab.com/react-admin/Routing.html#linking-to-a-page) instead.
+
+## `resolveRedirectTo` Helper Was Removed
+
+The `resolveRedirectTo` helper was removed. Use [`useCreatePath`](./Routing.html#linking-to-a-page) instead.
+
+## `formClassName` Prop Of `FieldProps` Type Was Removed
+
+The deprecated `formClassName` prop of `FieldProps` type has been removed as it is no longer used.
+
+## `formClassName` Prop Of `CommonInputProps` Type Was Removed
+
+The deprecated `formClassName` prop of `CommonInputProps` type has been removed as it is no longer used.
+
+## `PublicFieldProps` Interface Was Removed
+
+`PublicFieldProps` interface has been removed. Use `FieldProps` instead.
+
+## `InjectedFieldProps` Interface Was Removed
+
+`InjectedFieldProps` interface has been removed. Use `FieldProps` instead.
+
+## `<ThemeProvider theme>` Is No Longer Supported
+
+The deprecated `<ThemeProvider theme>` prop was removed. Use the `ThemesContext.Provider` instead:
+
+```diff
+-import { ThemeProvider } from 'react-admin';
++import { ThemeProvider, ThemesContext } from 'react-admin';
+
+ export const ThemeWrapper = ({ children }) => {
+     return (
+-        <ThemeProvider
+-            theme={{
+-                palette: { mode: 'dark' },
++        <ThemesContext.Provider
++            value={{
++                darkTheme: { palette: { mode: 'dark' } },
++                lightTheme: { palette: { mode: 'light' } },
+             }}
+         >
+-            {children}
+-        </ThemeProvider>
++            <ThemeProvider>{children}</ThemeProvider>
++        </ThemesContext.Provider>
+     );
+ };
+```
+
+## `<PaginationLimit>` Component Was Removed
+
+The deprecated `<PaginationLimit>` component was removed.
+
 ## TypeScript: `BulkActionProps` Type Has Been Removed
 
 The `BulkActionProps` has been removed as it did not contain any prop. You can safely remove it from your custom bulk actions.

packages/ra-core/src/auth/useCheckAuth.spec.tsx

@@ -21,20 +21,18 @@ const TestComponent = ({
     params,
     logoutOnFailure,
     redirectTo,
-    disableNotification,
 }: {
     params?: any;
     logoutOnFailure?: boolean;
     redirectTo?: string;
-    disableNotification?: boolean;
 }) => {
     const [authenticated, setAuthenticated] = useState(true);
     const checkAuth = useCheckAuth();
     useEffect(() => {
-        checkAuth(params, logoutOnFailure, redirectTo, disableNotification)
+        checkAuth(params, logoutOnFailure, redirectTo)
             .then(() => setAuthenticated(true))
             .catch(() => setAuthenticated(false));
-    }, [params, logoutOnFailure, redirectTo, disableNotification, checkAuth]);
+    }, [params, logoutOnFailure, redirectTo, checkAuth]);
     return <div>{authenticated ? 'authenticated' : 'not authenticated'}</div>;
 };
 
@@ -132,32 +130,6 @@ describe('useCheckAuth', () => {
         });
     });
 
-    it('should logout without showing a notification when disableNotification is true', async () => {
-        let location: Location;
-        render(
-            <TestMemoryRouter
-                initialEntries={['/']}
-                locationCallback={l => {
-                    location = l;
-                }}
-            >
-                <AuthContext.Provider value={authProvider}>
-                    <QueryClientProvider client={queryClient}>
-                        <TestComponent
-                            params={{ token: false }}
-                            disableNotification
-                        />
-                    </QueryClientProvider>
-                </AuthContext.Provider>
-            </TestMemoryRouter>
-        );
-        await waitFor(() => {
-            expect(notify).toHaveBeenCalledTimes(0);
-            expect(screen.queryByText('authenticated')).toBeNull();
-            expect(location.pathname).toBe('/login');
-        });
-    });
-
     it('should logout without showing a notification when authProvider returns error with message false', async () => {
         let location: Location;
         render(

packages/ra-core/src/auth/useCheckAuth.ts

@@ -52,12 +52,7 @@ export const useCheckAuth = (): CheckAuth => {
     );
 
     const checkAuth = useCallback(
-        (
-            params: any = {},
-            logoutOnFailure = true,
-            redirectTo = loginUrl,
-            disableNotification = false
-        ) =>
+        (params: any = {}, logoutOnFailure = true, redirectTo = loginUrl) =>
             authProvider.checkAuth(params).catch(error => {
                 if (logoutOnFailure) {
                     logout(
@@ -66,9 +61,7 @@ export const useCheckAuth = (): CheckAuth => {
                             ? error.redirectTo
                             : redirectTo
                     );
-                    const shouldSkipNotify =
-                        disableNotification ||
-                        (error && error.message === false);
+                    const shouldSkipNotify = error && error.message === false;
                     !shouldSkipNotify &&
                         notify(
                             getErrorMessage(error, 'ra.auth.auth_check_error'),
@@ -92,16 +85,13 @@ const checkAuthWithoutAuthProvider = () => Promise.resolve();
  * @param {Object} params The parameters to pass to the authProvider
  * @param {boolean} logoutOnFailure Whether the user should be logged out if the authProvider fails to authenticate them. True by default.
  * @param {string} redirectTo The login form url. Defaults to '/login'
- * @param {boolean} disableNotification Avoid showing a notification after the user is logged out. false by default.
  *
  * @return {Promise} Resolved to the authProvider response if the user passes the check, or rejected with an error otherwise
  */
 export type CheckAuth = (
     params?: any,
     logoutOnFailure?: boolean,
-    redirectTo?: string,
-    /** @deprecated to disable the notification, authProvider.checkAuth() should return an object with an error property set to true */
-    disableNotification?: boolean
+    redirectTo?: string
 ) => Promise<any>;
 
 const getErrorMessage = (error, defaultMessage) =>

packages/ra-core/src/auth/useLogoutIfAccessDenied.spec.tsx

@@ -39,18 +39,12 @@ const authProvider: AuthProvider = {
     getPermissions: () => Promise.reject('bad method'),
 };
 
-const TestComponent = ({
-    error,
-    disableNotification,
-}: {
-    error?: any;
-    disableNotification?: boolean;
-}) => {
+const TestComponent = ({ error }: { error?: any }) => {
     const [loggedOut, setLoggedOut] = useSafeSetState(false);
     const logoutIfAccessDenied = useLogoutIfAccessDenied();
     useEffect(() => {
-        logoutIfAccessDenied(error, disableNotification).then(setLoggedOut);
-    }, [error, disableNotification, logoutIfAccessDenied, setLoggedOut]);
+        logoutIfAccessDenied(error).then(setLoggedOut);
+    }, [error, logoutIfAccessDenied, setLoggedOut]);
     return <div>{loggedOut ? '' : 'logged in'}</div>;
 };
 
@@ -169,28 +163,6 @@ describe('useLogoutIfAccessDenied', () => {
         expect(screen.queryByText('logged in')).toBeNull();
     });
 
-    it('should logout without showing a notification if disableAuthentication is true', async () => {
-        render(
-            <Route
-                path="/"
-                element={
-                    <TestComponent
-                        error={new Error('denied')}
-                        disableNotification
-                    />
-                }
-            />,
-            {
-                wrapper: TestWrapper,
-            }
-        );
-        await waitFor(() => {
-            expect(authProvider.logout).toHaveBeenCalledTimes(1);
-            expect(notify).toHaveBeenCalledTimes(0);
-            expect(screen.queryByText('logged in')).toBeNull();
-        });
-    });
-
     it('should logout without showing a notification if authProvider returns error with message false', async () => {
         render(
             <TestMemoryRouter>
@@ -203,14 +175,7 @@ describe('useLogoutIfAccessDenied', () => {
                     }}
                 >
                     <Routes>
-                        <Route
-                            path="/"
-                            element={
-                                <>
-                                    <TestComponent />
-                                </>
-                            }
-                        />
+                        <Route path="/" element={<TestComponent />} />
                     </Routes>
                 </AuthContext.Provider>
             </TestMemoryRouter>
@@ -222,6 +187,22 @@ describe('useLogoutIfAccessDenied', () => {
         });
     });
 
+    it('should logout without showing a notification if it has been called with error param', async () => {
+        render(
+            <Route
+                path="/"
+                element={<TestComponent error={new Error('Error')} />}
+            />,
+            {
+                wrapper: TestWrapper,
+            }
+        );
+        await waitFor(() => {
+            expect(authProvider.logout).toHaveBeenCalledTimes(0);
+            expect(notify).toHaveBeenCalledTimes(0);
+        });
+    });
+
     it('should notify if passed an error with a message that makes the authProvider throw', async () => {
         render(
             <Route

packages/ra-core/src/auth/useLogoutIfAccessDenied.ts

@@ -44,13 +44,12 @@ const useLogoutIfAccessDenied = (): LogoutIfAccessDenied => {
     const notify = useNotify();
     const navigate = useNavigate();
     const logoutIfAccessDenied = useCallback(
-        (error?: any, disableNotification?: boolean) =>
+        (error?: any) =>
             authProvider
                 .checkError(error)
                 .then(() => false)
                 .catch(async e => {
                     const logoutUser = e?.logoutUser ?? true;
-
                     //manual debounce
                     if (timer) {
                         // side effects already triggered in this tick, exit
@@ -68,7 +67,6 @@ const useLogoutIfAccessDenied = (): LogoutIfAccessDenied => {
                             : undefined;
 
                     const shouldNotify = !(
-                        disableNotification ||
                         (e && e.message === false) ||
                         (error && error.message === false) ||
                         redirectTo?.startsWith('http')
@@ -127,15 +125,10 @@ const logoutIfAccessDeniedWithoutProvider = () => Promise.resolve(false);
  * If the authProvider rejects the call, logs the user out and shows a logged out notification.
  *
  * @param {Error} error An Error object (usually returned by the dataProvider)
- * @param {boolean} disableNotification Avoid showing a notification after the user is logged out. false by default.
  *
  * @return {Promise} Resolved to true if there was a logout, false otherwise
  */
-type LogoutIfAccessDenied = (
-    error?: any,
-    /** @deprecated to disable the notification, authProvider.checkAuth() should return an object with an error property set to true */
-    disableNotification?: boolean
-) => Promise<boolean>;
+type LogoutIfAccessDenied = (error?: any) => Promise<boolean>;
 
 const getErrorMessage = (error, defaultMessage) =>
     typeof error === 'string'

packages/ra-core/src/controller/button/useDeleteWithConfirmController.tsx

@@ -178,7 +178,6 @@ export interface UseDeleteWithConfirmControllerParams<
     mutationMode?: MutationMode;
     record?: RecordType;
     redirect?: RedirectionSideEffect;
-    // @deprecated. This hook get the resource from the context
     resource?: string;
     onClick?: ReactEventHandler<any>;
     mutationOptions?: UseMutationOptions<

packages/ra-core/src/controller/button/useDeleteWithUndoController.tsx

@@ -134,7 +134,6 @@ export interface UseDeleteWithUndoControllerParams<
 > {
     record?: RecordType;
     redirect?: RedirectionSideEffect;
-    // @deprecated. This hook get the resource from the context
     resource?: string;
     onClick?: ReactEventHandler<any>;
     mutationOptions?: UseMutationOptions<

packages/ra-core/src/controller/create/useCreateController.ts

@@ -213,9 +213,6 @@ export interface CreateControllerProps<
 export interface CreateControllerResult<
     RecordType extends Omit<RaRecord, 'id'> = any
 > extends SaveContextValue {
-    // Necessary for actions (EditActions) which expect a data prop containing the record
-    // @deprecated - to be removed in 4.0d
-    data?: RecordType;
     defaultTitle?: string;
     isFetching: boolean;
     isPending: boolean;

packages/ra-core/src/controller/input/useReferenceInputController.ts

@@ -7,9 +7,6 @@ import { ChoicesContextValue } from '../../form';
 import { useReferenceParams } from './useReferenceParams';
 import { UseQueryOptions } from '@tanstack/react-query';
 
-const defaultReferenceSource = (resource: string, source: string) =>
-    `${resource}@${source}`;
-
 /**
  * A hook for choosing a reference record. Useful for foreign keys.
  *
@@ -218,8 +215,6 @@ export interface UseReferenceInputControllerParams<
     perPage?: number;
     record?: RaRecord;
     reference: string;
-    // @deprecated ignored
-    referenceSource?: typeof defaultReferenceSource;
     resource?: string;
     sort?: SortPayload;
     source: string;

packages/ra-core/src/i18n/useLocale.tsx

@@ -15,8 +15,6 @@ import { useLocaleState } from './useLocaleState';
  *     const locale = useLocale();
  *     return <span>{availableLanguages[locale]}</span>;
  * }
- *
- * @deprecated use useLocaleState instead
  */
 export const useLocale = () => {
     const [locale] = useLocaleState();

packages/ra-core/src/i18n/useSetLocale.tsx

@@ -23,8 +23,6 @@ import { useLocaleState } from './useLocaleState';
  *         }</ul>
  *     );
  * }
- *
- * @deprecated use useLocaleState instead
  */
 export const useSetLocale = () => {
     const [, setLocale] = useLocaleState();