-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated props #9789
Merged
Merged
Remove deprecated props #9789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
reviewed
Apr 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far, so good!
Co-authored-by: Francois Zaninotto <[email protected]>
…irmController are no longer deprecated
fzaninotto
requested changes
Apr 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good so far
fzaninotto
approved these changes
Apr 25, 2024
I think we can de-deprecate and keep in v5 the following hooks
|
djhi
approved these changes
Apr 29, 2024
erwanMarmelab
approved these changes
Apr 30, 2024
djhi
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some props are deprecated
Solution
Remove them
TODO
Remove:
disableNotification
fromuseCheckAuth
disableNotification
fromuseLogoutIfAccessDenied
resource
fromuseDeleteWithConfirmController
resource
fromuseDeleteWithUndoController
data
fromCreateControllerResult
referenceSource
fromuseReferenceInputController
saving
fromSaveContextValue
? 🤔 -> lateruseGetValidationErrorMessage
? 🤔 -> later<ArrayInput>
has to be adapteduseLocale
useSetLocale
linkToRecord
resolveRedirectTo
onError
type from ra-core type.tsformClassName
fromFieldProps
fullWidth
fromFieldProps
PublicFieldProps
fromFieldProps
InjectedFieldProps
fromFieldProps
formClassName
fromCommonInputProps
sidebarIsOpen
fromDashboardMenuItem
-> latersidebarIsOpen
fromMenuItemLink
-> laterrowStyle
fromDatagrid
PaginationLimit
rowStyle
fromSimpleList
theme
fromThemeProvider