[RFR] Allow to display the listView even with missing references #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
force-pushed
the
reference_failed
branch
from
b0afec0
to
e22c825
Compare
fzaninotto
changed the title
|
Switching to RFR |
|
bumps, tests are green locally. |
| states[key] = true; | ||
| results[key] = result; // result may be an error | ||
| var allFinished = true; | ||
| states.forEach(function (state) { |
There was a problem hiding this comment.
Can you use a for statement to be able to break the loop when we find a !state ?
|
Review applied |
fzaninotto
force-pushed
the
reference_failed
branch
from
a773d02
to
30223f1
Compare
|
Green and reviewed |
manuquentin
added a commit
that referenced
this pull request
Mar 31, 2015
[RFR] Allow to display the listView even with missing references
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #346