Code review

marmelab · Mar 18, 2015 · a773d02 · a773d02
1 parent 4b244b3
commit a773d02
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/src/javascripts/ng-admin/Crud/misc/PromisesResolver.js b/src/javascripts/ng-admin/Crud/misc/PromisesResolver.js
@@ -25,15 +25,12 @@ define(function () {
                 function resolve(result) {
                     states[key] = true;
                     results[key] = result; // result may be an error
-                    var allFinished = true;
-                    states.forEach(function (state) {
-                        if (!state) {
-                            allFinished = false;
+                    for (var i in states) {
+                        if (!states[i]) {
+                            return;
                         }
-                    });
-                    if (allFinished) {
-                        deferred.resolve(results);
                     }
+                    deferred.resolve(results);
                 }
                 function resolveSuccess(result) {
                     return resolve({ status: 'success', result: result });