update list_attributions to not filter out current project's attributions #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markgdawson
reviewed
Aug 6, 2019
| path( | ||
| 'list_attributions/<int:pk>', | ||
| views.list_attributions, | ||
| name='list_attributions', |
There was a problem hiding this comment.
It doesn't actually matter at all in this case, but could give these unique?
Also, I've just noticed that this route uses underscores, whereas lots of others hyphens. Maybe we can make that more consistent while we're at it?
There was a problem hiding this comment.
@edbennett I'll just make these minor changes myself and merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes edbennett#106