Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Unable to load icons for JIRA ticket #49

Closed
2 of 5 tasks
maxgohfp opened this issue Dec 28, 2022 · 4 comments
Closed
2 of 5 tasks

[Bug] Unable to load icons for JIRA ticket #49

maxgohfp opened this issue Dec 28, 2022 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@maxgohfp
Copy link

maxgohfp commented Dec 28, 2022

Describe the bug
Firstly, thanks for creating this plugin. I love it. However, I'm creating errors when loading the icon of the ticket.

Screenshot 2022-12-28 at 3 20 40 PM

I traced through developer logs. It does seem like there's a permission issue as I tried to open the link via incognito on my browser, and there's an additional layer of authentication prior to accessing the static image. Is there a workaround that I can do?

In the network logs, I'm getting status code 302, with the response "Failed to load response data: No content available because this request was redirected".

Perhaps, I can add some static icons locally? I don't really care about the icons, but it's an eye sore when viewing through my notes.

To Reproduce
Steps to reproduce the behavior:

  1. Just type JIRA:Ticket-123

Expected behavior
I expect the ticket to load the correct icon properly.

Screenshots
If applicable, add screenshots to help explain your problem.

Plugin version and platform

  • Version: 1.48.0
  • Obsidian Windows
  • Obsidian Mac
  • Obsidian Linux
  • Obsidian Android
  • Obsidian iOS
@maxgohfp maxgohfp added the bug Something isn't working label Dec 28, 2022
@marc0l92 marc0l92 moved this to Backlog in obsidian-jira-issue Jan 11, 2023
@Rosswell
Copy link

Rosswell commented Jan 12, 2023

im experiencing the same issue - if its not fixable due to permissions, perhaps an alternative would be to allow users to select the shown columns for the inline issues, as is the case with the table view?

more detail beyond the 302 redirect:
looks like its due to SSO/SAML CORB goodness, for me at least -

Cross-Origin Read Blocking (CORB) blocked cross-origin response https://companyDomain.login.duosecurity.com/email_first?authkey=blahblah&aid=blahblah with MIME type text/html. See https://www.chromestatus.com/feature/5629709824032768 for more details.

from this bit: https://github.com/marc0l92/obsidian-jira-issue/blob/master/src/client/jiraClient.ts#L34

i believe its related to this: https://jira.atlassian.com/browse/JRASERVER-72378
the icon urls are not rest apis, so passing the bearer token auth doesn't do anything, and it attempts to redirect to sso login. sigh

@hilsonp
Copy link

hilsonp commented Feb 27, 2023

Indeed, I get the same issue. Having a way to hide the broken icon if it is not possible to work-around the problem would be nice.

@maxgohfp
Copy link
Author

As a workaround, I went into the compiled main.js and removed the column from the code. It looks much more appropriate now without the icons.

I can share what I change when I get sometime later if necessary.

Screenshot 2023-02-27 at 4 43 56 PM

marc0l92 added a commit that referenced this issue May 30, 2023
marc0l92 added a commit that referenced this issue May 30, 2023
marc0l92 added a commit that referenced this issue May 30, 2023
@marc0l92
Copy link
Owner

Hello, please update the plugin to version 1.54.0. It should hide the images that I'm not able to fetch.
Since I cannot test it, let me know how it looks like

@marc0l92 marc0l92 closed this as completed Jun 2, 2023
@marc0l92 marc0l92 moved this from Backlog to Done in obsidian-jira-issue Nov 12, 2023
wbh1 added a commit to wbh1/obsidian-jira-issue that referenced this issue Aug 21, 2024
related to marc0l92#32 and marc0l92#49

This adds a per-account setting to disable fetching of icons from the specified Jira server and instead use icons provided upstream by Atlassian.

It is useful in cases where you cannot fetch icons (e.g. due to permission issues), but would still like icons displayed instead of the current placeholder broken image icon.
wbh1 added a commit to wbh1/obsidian-jira-issue that referenced this issue Aug 21, 2024
related to marc0l92#32 and marc0l92#49

This adds a per-account setting to disable fetching of icons from the specified Jira server and instead use icons provided upstream by Atlassian.

It is useful in cases where you cannot fetch icons (e.g. due to permission issues), but would still like icons displayed instead of the current placeholder broken image icon.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

4 participants