Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarkus and MapStruct blog entry #100

Merged
merged 4 commits into from
Dec 6, 2019

Conversation

chris922
Copy link
Member

@chris922 chris922 commented Dec 3, 2019

I finally updated the blog entry (+ example, see PR mapstruct/mapstruct-examples#74) to Quarkus 1.0.1.Final.

Please have a look and feel free to make some changes or give some feedback what I should change :)

Before it will be published the date (filename + fileheader) should be adjusted as well.

Copy link
Member

@filiphr filiphr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good @chris922. I added some comments inline, mostly some typos.

One other thing that I noticed. You write "the GraalVM", I think we can drop the "the" and write only "GraalVM" instead. WDYT?

content/news/2019-12-03-mapstruct-and-quarkus.md Outdated Show resolved Hide resolved
content/news/2019-12-03-mapstruct-and-quarkus.md Outdated Show resolved Hide resolved
content/news/2019-12-03-mapstruct-and-quarkus.md Outdated Show resolved Hide resolved
Copy link
Member

@gunnarmorling gunnarmorling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @chris922! A few small comments inline.

content/news/2019-12-03-mapstruct-and-quarkus.md Outdated Show resolved Hide resolved
content/news/2019-12-03-mapstruct-and-quarkus.md Outdated Show resolved Hide resolved
content/news/2019-12-03-mapstruct-and-quarkus.md Outdated Show resolved Hide resolved
content/news/2019-12-03-mapstruct-and-quarkus.md Outdated Show resolved Hide resolved
content/news/2019-12-03-mapstruct-and-quarkus.md Outdated Show resolved Hide resolved
content/news/2019-12-03-mapstruct-and-quarkus.md Outdated Show resolved Hide resolved
content/news/2019-12-03-mapstruct-and-quarkus.md Outdated Show resolved Hide resolved
content/news/2019-12-03-mapstruct-and-quarkus.md Outdated Show resolved Hide resolved
content/news/2019-12-03-mapstruct-and-quarkus.md Outdated Show resolved Hide resolved
content/news/2019-12-03-mapstruct-and-quarkus.md Outdated Show resolved Hide resolved
@gsmet
Copy link

gsmet commented Dec 4, 2019

Jumping in, we have quite a lot of questions about lazy initialization errors with Hibernate for which the answer is using something similar to MapStruct.

Would it be possible to write a Quarkus guide and quickstart for it? I can guide you through the process if you're inclined to do it.

@chris922
Copy link
Member Author

chris922 commented Dec 4, 2019

Thanks for your feedback @filiphr and @gunnarmorling . I really appreciate it! 😃
Is it now fine for you two?

I set the date to tomorrow, so when we merge it it will be visible earliest tomorrow 😄

@gsmet if you provide us a few more information what actually is the issue we can take a look at it. Sounds interesting as well :)

@gunnarmorling
Copy link
Member

gunnarmorling commented Dec 4, 2019

Is it now fine for you two?

I'm sure it's good :)

I set the date to tomorrow, so when we merge it it will be visible earliest tomorrow

Anything speaking against publishing it today? Getting it out on Wednesday leaves you with two days of runway (i.e. more viewers) before the weekend slowness kicks in.

@gsmet
Copy link

gsmet commented Dec 4, 2019

Well, it's not an issue per se. It's just that people are returning directly serializing their entities as JSON and this is done outside of the transaction layer so they get a lazy initialization exception.

This is a known issue and one of the (elegant) solution is to use MapStruct-like components. Having a small guide + quickstart on the quarkus.io website would help.

For an example of a guide + quickstart:

It probably would be a bit simpler but you get the idea.

I would be happy to assist or answer any questions.

@gunnarmorling
Copy link
Member

👍 Having a MapStruct guide on quarkus.io is a great idea! It'd also raise awareness of MapStruct in the Quarkus context -- due to its nature of avoiding reflection it's the natural choice of a mapper for Quarkus, as you nicely point out in this post.

Note the Kafka Streams guide is one of the longer ones, the MapStruct one could be quite concise. What would be nice is to have this issue with the dev reload being fixed only to enable the recommended usage of MapStruct on the annotationProcessorPath.

Copy link

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few comments and suggestions.

content/news/2019-12-03-mapstruct-and-quarkus.md Outdated Show resolved Hide resolved
content/news/2019-12-03-mapstruct-and-quarkus.md Outdated Show resolved Hide resolved
content/news/2019-12-03-mapstruct-and-quarkus.md Outdated Show resolved Hide resolved
content/news/2019-12-03-mapstruct-and-quarkus.md Outdated Show resolved Hide resolved
content/news/2019-12-03-mapstruct-and-quarkus.md Outdated Show resolved Hide resolved
content/news/2019-12-03-mapstruct-and-quarkus.md Outdated Show resolved Hide resolved
content/news/2019-12-03-mapstruct-and-quarkus.md Outdated Show resolved Hide resolved
content/news/2019-12-03-mapstruct-and-quarkus.md Outdated Show resolved Hide resolved
Copy link
Member

@filiphr filiphr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @chris922. I have no problem in releasing it today. I see that @gsmet added some more comments. Feel free to merge it once it is ready @chris922.

The publish is not yet automatic, so someone would need to trigger a publish. I would be able to do it until 18:30 or after 21:00.

@filiphr
Copy link
Member

filiphr commented Dec 4, 2019

Oh and I am also 👍 for having a quick-start with MapStruct and Quarkus. @chris922 would you like to drive that as well?

@chris922
Copy link
Member Author

chris922 commented Dec 4, 2019

Thanks @gsmet! I could have a look at the quick start at the weekend, would really be a great opportunity for mapstruct to make it more visible!

@gunnarmorling and @filiphr: I was not at home the whole evening, I will try to release it tomorrow :) I really appreciate all your feedback guys!
Publishing it was just starting the shell script? I already did it once in the past and as far as I remember it was really simple.

@filiphr
Copy link
Member

filiphr commented Dec 5, 2019

Publishing it was just starting the shell script? I already did it once in the past and as far as I remember it was really simple.

Yes it is really simple. Detailed instructions are here on our website. and the script is this. Keep in mind you need to have hugo v0.30.2 (need to fix this, I know 😄)

@gunnarmorling
Copy link
Member

@chris922, are you planning to publish this today? If so, let me know once it's done and I can tweet from the MapStruct handle.

@gunnarmorling
Copy link
Member

In terms of a quickstart -- or more generically, a proper Quarkus extension -- I've logged quarkusio/quarkus#5956 over in the Quarkus project. Any help would be highly welcomed :)

@chris922 chris922 merged commit 45fab60 into mapstruct:master Dec 6, 2019
@chris922 chris922 deleted the quarkus-blog-entry branch December 6, 2019 14:14
@chris922
Copy link
Member Author

chris922 commented Dec 6, 2019

Yesterday we had a full-day team event and I was not able to find some free minutes.. but now I finally found them and published the post. Thanks again for your support :)
-> https://twitter.com/cbandowski/status/1202959353675952133 & https://mapstruct.org/news/2019-12-06-mapstruct-and-quarkus/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants