-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quarkus and MapStruct blog entry #100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good @chris922. I added some comments inline, mostly some typos.
One other thing that I noticed. You write "the GraalVM", I think we can drop the "the" and write only "GraalVM" instead. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, @chris922! A few small comments inline.
Jumping in, we have quite a lot of questions about lazy initialization errors with Hibernate for which the answer is using something similar to MapStruct. Would it be possible to write a Quarkus guide and quickstart for it? I can guide you through the process if you're inclined to do it. |
Thanks for your feedback @filiphr and @gunnarmorling . I really appreciate it! 😃 I set the date to tomorrow, so when we merge it it will be visible earliest tomorrow 😄 @gsmet if you provide us a few more information what actually is the issue we can take a look at it. Sounds interesting as well :) |
I'm sure it's good :)
Anything speaking against publishing it today? Getting it out on Wednesday leaves you with two days of runway (i.e. more viewers) before the weekend slowness kicks in. |
Well, it's not an issue per se. It's just that people are returning directly serializing their entities as JSON and this is done outside of the transaction layer so they get a lazy initialization exception. This is a known issue and one of the (elegant) solution is to use MapStruct-like components. Having a small guide + quickstart on the quarkus.io website would help. For an example of a guide + quickstart:
It probably would be a bit simpler but you get the idea. I would be happy to assist or answer any questions. |
👍 Having a MapStruct guide on quarkus.io is a great idea! It'd also raise awareness of MapStruct in the Quarkus context -- due to its nature of avoiding reflection it's the natural choice of a mapper for Quarkus, as you nicely point out in this post. Note the Kafka Streams guide is one of the longer ones, the MapStruct one could be quite concise. What would be nice is to have this issue with the dev reload being fixed only to enable the recommended usage of MapStruct on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few comments and suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh and I am also 👍 for having a quick-start with MapStruct and Quarkus. @chris922 would you like to drive that as well? |
Thanks @gsmet! I could have a look at the quick start at the weekend, would really be a great opportunity for mapstruct to make it more visible! @gunnarmorling and @filiphr: I was not at home the whole evening, I will try to release it tomorrow :) I really appreciate all your feedback guys! |
@chris922, are you planning to publish this today? If so, let me know once it's done and I can tweet from the MapStruct handle. |
In terms of a quickstart -- or more generically, a proper Quarkus extension -- I've logged quarkusio/quarkus#5956 over in the Quarkus project. Any help would be highly welcomed :) |
Yesterday we had a full-day team event and I was not able to find some free minutes.. but now I finally found them and published the post. Thanks again for your support :) |
I finally updated the blog entry (+ example, see PR mapstruct/mapstruct-examples#74) to Quarkus 1.0.1.Final.
Please have a look and feel free to make some changes or give some feedback what I should change :)
Before it will be published the date (filename + fileheader) should be adjusted as well.