Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Quarkus example to use Quarkus 1.0.1.Final #74

Merged
merged 1 commit into from
Dec 4, 2019
Merged

Update Quarkus example to use Quarkus 1.0.1.Final #74

merged 1 commit into from
Dec 4, 2019

Conversation

chris922
Copy link
Member

@chris922 chris922 commented Oct 17, 2019 •
edited
Loading

I updated the Quarkus example to use the up-to-date version 1.0.1.Final

@chris922
Copy link
Member Author

Has someone an idea why google-maven-central will be used here? Never heard about this maven central clone (?).. is this configured in Travis, @filiphr ?

[ERROR] Plugin io.quarkus:quarkus-maven-plugin:0.25.0 or one of its dependencies could not be resolved: Could not find artifact io.quarkus:quarkus-maven-plugin:jar:0.25.0 in google-maven-central (https://maven-central.storage-download.googleapis.com/repos/central/data/) -> [Help 1]

@chris922 chris922 force-pushed the update-quarkus-example branch from d864a44 to 8956d8e Compare December 3, 2019 20:29
@chris922 chris922 force-pushed the update-quarkus-example branch from 8956d8e to 937857d Compare December 3, 2019 20:31
@chris922 chris922 changed the title Update Quarkus example to use Quarkus 0.25.0 Update Quarkus example to use Quarkus 1.0.1.Final Dec 3, 2019
@chris922 chris922 mentioned this pull request Dec 3, 2019
Merged
filiphr
filiphr approved these changes Dec 3, 2019
View reviewed changes
Copy link
Member

@filiphr filiphr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Perhaps it can be a good idea to automatically create those GraalVM features from our side as well, via some configuration of the processor

@chris922
Copy link
Member Author

chris922 commented Dec 4, 2019

Thanks @filiphr !

Perhaps it can be a good idea to automatically create those GraalVM features from our side as well, via some configuration of the processor

I would love if MapStruct will do this so it is 100% compatible with GraalVM

@chris922 chris922 merged commit 2f35157 into mapstruct:master Dec 4, 2019
@chris922 chris922 deleted the update-quarkus-example branch December 4, 2019 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filiphr filiphr filiphr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chris922 @filiphr