-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add telemetry events #304
Merged
Merged
Add telemetry events #304
Changes from 79 commits
Commits
Show all changes
92 commits
Select commit
Hold shift + click to select a range
3215921
Begin adding telem events
4f85bdf
fix
530ae77
add timezone
cff594f
Update
3b05ad0
Add remaining events
6fa8b98
conditional import
8b61ab9
Move back to core
a1ac9cd
make private
4170144
Consolidate telemetry state, outline full telemetry spec
ericrwolfe 7c19139
Update date format
ericrwolfe ae3606f
Store more state; add device
ericrwolfe 582801f
Updated telemetry event handling
ericrwolfe e9ab2d3
Round events
ericrwolfe c48a740
Add dialog view controller
frederoni 98f1e78
Reset telemetry session if route updated after arrival
ericrwolfe d3f70ac
Remove logs; trailing closure syntax
ericrwolfe a207c3e
Add userId to feedback event
ericrwolfe 35ef0c5
Hide feedback dialog after 0.5s
ericrwolfe b2305b7
Moar trailing closure
ericrwolfe c07dc9c
Add temporary pod dependency on Mapbox-iOS-SDK
ericrwolfe 5021c6c
Pass nil feedback description for now
ericrwolfe a445dd5
Extend locations collected
ericrwolfe 8d6dcbd
Fix location serialization
ericrwolfe e83e0c9
Reduce locations collected
ericrwolfe 3fab48f
More battery level precision
ericrwolfe 82577e2
remove battery enable flag
3dc4b66
Merge branch 'master' into telem
650aa53
Add snapshot to reroute event
frederoni 7bf9429
Add update + cancel feedback functions
ericrwolfe 51b419b
Screenshots as jpeg
ericrwolfe 5f7fb85
Fixed bugs in closestCoordinate and addArrow functions. (#284)
hardsetting 872a078
Fix location permissions and adopt iOS 11 description
frederoni 19d8004
Wait until style has loaded before doing things to it (#339)
00a9e70
Defer simulated location updates until next run loop (#344)
ericrwolfe 88292e6
Did arrive once (#347)
723ffe3
Merge branch 'master' into telem
8c331f6
Merge branch 'master' into telem
27a92b3
add back
6268d1e
Merge branch 'master' into telem
1ca06a3
Use telem library
ec4d0c8
add init
752a434
add
094dc75
add release
9090a7d
Merge branch 'master' into telem
d916e79
fix string
0ab1844
Merge branch 'master' into telem
bb7a0a1
updater
689ad01
fix
270667f
update args
3ab3f60
add framework
1facf0d
add certs
dd9e1a3
move certs
afebe4e
struct
f215025
more struct
c7f94ba
add
b0a518f
add to tests
caee403
add to obj-c
733d113
Merge branch 'master' into telem
1af385c
Merge branch 'master' into telem
50f4621
remove
e73102b
update
efba1ef
bump
54eecec
Merge branch 'master' into telem
a0f12ee
Add upcoming step information
ericrwolfe fa2a1c5
Remove telem staging token check (handled upstream)
ericrwolfe be98692
Add previous step information
ericrwolfe 93f9584
Only capitalize first character of step maneuver keys
ericrwolfe 97467ea
copy framework
ca8d37b
trailing
3bbf17c
add framework
f183ab5
add access token
783de5d
fix
94ead77
make optional
0c1a57f
rename
e8d1c55
update event lib
982eefa
Merge branch 'master' into telem
adf4bed
name not version
12a51b4
Better types
24440b5
Merge branch 'master' into telem
3d5b8ef
Update
d72d8b3
No telem in sim
a013625
add back
cd42c00
Dont pass in access token
c90e03e
fix
90b18a9
Switch to nested step dictionary in feedback events
ericrwolfe 621c2f4
Add debug metrics user info key
ericrwolfe 572cde4
Fix feedback event types
ericrwolfe e04bb09
Moved all event dictionary generation to MMEEventsManager
ericrwolfe bf2e536
Move feedback event dict update logic
ericrwolfe 1a07311
Bump
5dec73b
Merge branch 'master' into telem
ericrwolfe a7b8e1a
Pin to MapboxDirections.swift 0.10.1
ericrwolfe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
extension Date { | ||
var ISO8601: String { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Too bad |
||
let formatter = DateFormatter() | ||
formatter.locale = Locale(identifier: "en_US_POSIX") | ||
formatter.dateFormat = "yyyy-MM-dd'T'HH:mm:ss.SSSZ" | ||
formatter.timeZone = TimeZone(secondsFromGMT: 0) | ||
return formatter.string(from: self) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
import Foundation | ||
|
||
@objc(MBFeedbackType) | ||
public enum FeedbackType: Int, CustomStringConvertible { | ||
case general | ||
|
||
public init?(description: String) { | ||
let level: FeedbackType | ||
switch description { | ||
case "general": | ||
level = .general | ||
default: | ||
return nil | ||
} | ||
self.init(rawValue: level.rawValue) | ||
} | ||
|
||
public var description: String { | ||
switch self { | ||
case .general: | ||
return "general" | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does MapboxNavigation-Documentation.podspec need to be updated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep https://github.com/mapbox/mapbox-navigation-ios/pull/304/files#diff-24463e219dc9d9fdb8dfde3c38cef64cR52